fix formatting

src/main/java/com/commafeed/backend/cache/RedisCacheService.java

@@ -5,12 +5,6 @@ import java.util.List;
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-import redis.clients.jedis.Jedis;
-import redis.clients.jedis.JedisPool;
-import redis.clients.jedis.Pipeline;
-
 import com.commafeed.backend.model.Feed;
 import com.commafeed.backend.model.FeedSubscription;
 import com.commafeed.backend.model.Models;
@@ -20,11 +14,17 @@ import com.commafeed.frontend.model.UnreadCount;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import redis.clients.jedis.Jedis;
+import redis.clients.jedis.JedisPool;
+import redis.clients.jedis.Pipeline;
+
 @Slf4j
 @RequiredArgsConstructor
 public class RedisCacheService extends CacheService {
 
-	private static ObjectMapper MAPPER = new ObjectMapper();
+	private static final ObjectMapper MAPPER = new ObjectMapper();
 
 	private final JedisPool pool;
 

src/main/java/com/commafeed/backend/cache/RedisPoolFactory.java

@@ -1,22 +1,21 @@
 package com.commafeed.backend.cache;
 
-import lombok.Getter;
-
 import org.apache.commons.lang3.StringUtils;
 
+import lombok.Getter;
 import redis.clients.jedis.JedisPool;
 import redis.clients.jedis.JedisPoolConfig;
 import redis.clients.jedis.Protocol;
 
 @Getter
 public class RedisPoolFactory {
-	private String host = "localhost";
-	private int port = Protocol.DEFAULT_PORT;
-	private String password = null;
-	private int timeout = Protocol.DEFAULT_TIMEOUT;
-	private int database = Protocol.DEFAULT_DATABASE;
+	private final String host = "localhost";
+	private final int port = Protocol.DEFAULT_PORT;
+	private String password;
+	private final int timeout = Protocol.DEFAULT_TIMEOUT;
+	private final int database = Protocol.DEFAULT_DATABASE;
 
-	private int maxTotal = 500;
+	private final int maxTotal = 500;
 
 	public JedisPool build() {
 		JedisPoolConfig config = new JedisPoolConfig();

src/main/java/com/commafeed/backend/dao/FeedEntryStatusDAO.java

@@ -38,6 +38,18 @@ import com.querydsl.jpa.impl.JPAQuery;
 @Singleton
 public class FeedEntryStatusDAO extends GenericDAO<FeedEntryStatus> {
 
+	private static final Comparator<FeedEntryStatus> STATUS_COMPARATOR_DESC = new Comparator<FeedEntryStatus>() {
+		@Override
+		public int compare(FeedEntryStatus o1, FeedEntryStatus o2) {
+			CompareToBuilder builder = new CompareToBuilder();
+			builder.append(o2.getEntryUpdated(), o1.getEntryUpdated());
+			builder.append(o2.getId(), o1.getId());
+			return builder.toComparison();
+		}
+	};
+
+	private static final Comparator<FeedEntryStatus> STATUS_COMPARATOR_ASC = Ordering.from(STATUS_COMPARATOR_DESC).reverse();
+
 	private final FeedEntryDAO feedEntryDAO;
 	private final FeedEntryTagDAO feedEntryTagDAO;
 	private final CommaFeedConfiguration config;
@@ -56,18 +68,6 @@ public class FeedEntryStatusDAO extends GenericDAO<FeedEntryStatus> {
 		this.config = config;
 	}
 
-	private static final Comparator<FeedEntryStatus> STATUS_COMPARATOR_DESC = new Comparator<FeedEntryStatus>() {
-		@Override
-		public int compare(FeedEntryStatus o1, FeedEntryStatus o2) {
-			CompareToBuilder builder = new CompareToBuilder();
-			builder.append(o2.getEntryUpdated(), o1.getEntryUpdated());
-			builder.append(o2.getId(), o1.getId());
-			return builder.toComparison();
-		}
-	};
-
-	private static final Comparator<FeedEntryStatus> STATUS_COMPARATOR_ASC = Ordering.from(STATUS_COMPARATOR_DESC).reverse();
-
 	public FeedEntryStatus getStatus(User user, FeedSubscription sub, FeedEntry entry) {
 		List<FeedEntryStatus> statuses = query().selectFrom(status).where(status.entry.eq(entry), status.subscription.eq(sub)).fetch();
 		FeedEntryStatus status = Iterables.getFirst(statuses, null);

src/main/java/com/commafeed/backend/dao/UnitOfWork.java

@@ -7,16 +7,6 @@ import org.hibernate.context.internal.ManagedSessionContext;
 
 public class UnitOfWork {
 
-	@FunctionalInterface
-	public static interface SessionRunner {
-		public void runInSession();
-	}
-
-	@FunctionalInterface
-	public static interface SessionRunnerReturningValue<T> {
-		public T runInSession();
-	}
-
 	public static void run(SessionFactory sessionFactory, SessionRunner sessionRunner) {
 		call(sessionFactory, () -> {
 			sessionRunner.runInSession();
@@ -66,4 +56,14 @@ public class UnitOfWork {
 		throw (E) e;
 	}
 
+	@FunctionalInterface
+	public interface SessionRunner {
+		void runInSession();
+	}
+
+	@FunctionalInterface
+	public interface SessionRunnerReturningValue<T> {
+		T runInSession();
+	}
+
 }

src/main/java/com/commafeed/backend/favicon/AbstractFaviconFetcher.java

@@ -3,22 +3,22 @@ package com.commafeed.backend.favicon;
 import java.util.Arrays;
 import java.util.List;
 
-import lombok.Getter;
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.lang3.StringUtils;
 
 import com.commafeed.backend.model.Feed;
 
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 @Slf4j
 public abstract class AbstractFaviconFetcher {
 
-	private static List<String> ICON_MIMETYPE_BLACKLIST = Arrays.asList("application/xml", "text/html");
-	private static long MIN_ICON_LENGTH = 100;
-	private static long MAX_ICON_LENGTH = 100000;
+	protected static final int TIMEOUT = 4000;
 
-	protected static int TIMEOUT = 4000;
+	private static final List<String> ICON_MIMETYPE_BLACKLIST = Arrays.asList("application/xml", "text/html");
+	private static final long MIN_ICON_LENGTH = 100;
+	private static final long MAX_ICON_LENGTH = 100000;
 
 	public abstract Favicon fetch(Feed feed);
 

src/main/java/com/commafeed/backend/favicon/DefaultFaviconFetcher.java

@@ -3,9 +3,6 @@ package com.commafeed.backend.favicon;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.lang3.StringUtils;
 import org.jsoup.Jsoup;
 import org.jsoup.nodes.Document;
@@ -16,6 +13,9 @@ import com.commafeed.backend.HttpGetter.HttpResult;
 import com.commafeed.backend.feed.FeedUtils;
 import com.commafeed.backend.model.Feed;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 /**
  * Inspired/Ported from https://github.com/potatolondon/getfavicon
  * 

src/main/java/com/commafeed/backend/favicon/FacebookFaviconFetcher.java

@@ -8,9 +8,6 @@ import java.util.List;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.http.NameValuePair;
 import org.apache.http.client.utils.URLEncodedUtils;
 
@@ -18,6 +15,9 @@ import com.commafeed.backend.HttpGetter;
 import com.commafeed.backend.HttpGetter.HttpResult;
 import com.commafeed.backend.model.Feed;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 @Slf4j
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton

src/main/java/com/commafeed/backend/favicon/YoutubeFaviconFetcher.java

@@ -28,7 +28,7 @@ import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-@RequiredArgsConstructor(onConstructor = @__({ @Inject }) )
+@RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class YoutubeFaviconFetcher extends AbstractFaviconFetcher {
 

src/main/java/com/commafeed/backend/feed/FeedEntryKeyword.java

@@ -3,11 +3,11 @@ package com.commafeed.backend.feed;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.StringUtils;
+
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 
-import org.apache.commons.lang3.StringUtils;
-
 /**
  * A keyword used in a search query
  */
@@ -15,7 +15,7 @@ import org.apache.commons.lang3.StringUtils;
 @RequiredArgsConstructor
 public class FeedEntryKeyword {
 
-	public static enum Mode {
+	public enum Mode {
 		INCLUDE, EXCLUDE;
 	}
 

src/main/java/com/commafeed/backend/feed/FeedFetcher.java

@@ -86,8 +86,9 @@ public class FeedFetcher {
 	private static String extractFeedUrl(Set<FeedURLProvider> urlProviders, String url, String urlContent) {
 		for (FeedURLProvider urlProvider : urlProviders) {
 			String feedUrl = urlProvider.get(url, urlContent);
-			if (feedUrl != null)
+			if (feedUrl != null) {
 				return feedUrl;
+			}
 		}
 
 		return null;

src/main/java/com/commafeed/backend/feed/FeedParser.java

@@ -48,7 +48,7 @@ public class FeedParser {
 	private static final Namespace ATOM_10_NS = Namespace.getNamespace(ATOM_10_URI);
 
 	private static final Date START = new Date(86400000);
-	private static final Date END = new Date(1000l * Integer.MAX_VALUE - 86400000);
+	private static final Date END = new Date(1000L * Integer.MAX_VALUE - 86400000);
 
 	public FetchedFeed parse(String feedUrl, byte[] xml) throws FeedException {
 		FetchedFeed fetchedFeed = new FetchedFeed();

src/main/java/com/commafeed/backend/feed/FeedRefreshContext.java

@@ -2,12 +2,12 @@ package com.commafeed.backend.feed;
 
 import java.util.List;
 
-import lombok.Getter;
-import lombok.Setter;
-
 import com.commafeed.backend.model.Feed;
 import com.commafeed.backend.model.FeedEntry;
 
+import lombok.Getter;
+import lombok.Setter;
+
 @Getter
 @Setter
 public class FeedRefreshContext {

src/main/java/com/commafeed/backend/feed/FeedRefreshExecutor.java

@@ -81,10 +81,6 @@ public class FeedRefreshExecutor {
 		pool.execute(task);
 	}
 
-	public static interface Task extends Runnable {
-		boolean isUrgent();
-	}
-
 	public void shutdown() {
 		pool.shutdownNow();
 		while (!pool.isTerminated()) {
@@ -95,4 +91,9 @@ public class FeedRefreshExecutor {
 			}
 		}
 	}
+
+	public interface Task extends Runnable {
+		boolean isUrgent();
+	}
+
 }

src/main/java/com/commafeed/backend/feed/FeedRefreshTaskGiver.java

@@ -1,20 +1,19 @@
 package com.commafeed.backend.feed;
 
-import io.dropwizard.lifecycle.Managed;
-
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.extern.slf4j.Slf4j;
-
 import com.codahale.metrics.Meter;
 import com.codahale.metrics.MetricRegistry;
 import com.commafeed.CommaFeedConfiguration;
 import com.commafeed.backend.dao.FeedDAO;
 
+import io.dropwizard.lifecycle.Managed;
+import lombok.extern.slf4j.Slf4j;
+
 /**
  * Infinite loop fetching feeds from @FeedQueues and queuing them to the {@link FeedRefreshWorker} pool.
  * 
@@ -26,10 +25,10 @@ public class FeedRefreshTaskGiver implements Managed {
 	private final FeedQueues queues;
 	private final FeedRefreshWorker worker;
 
-	private ExecutorService executor;
+	private final ExecutorService executor;
 
-	private Meter feedRefreshed;
-	private Meter threadWaited;
+	private final Meter feedRefreshed;
+	private final Meter threadWaited;
 
 	@Inject
 	public FeedRefreshTaskGiver(FeedQueues queues, FeedDAO feedDAO, FeedRefreshWorker worker, CommaFeedConfiguration config,

src/main/java/com/commafeed/backend/feed/FeedRefreshUpdater.java

@@ -49,13 +49,13 @@ public class FeedRefreshUpdater implements Managed {
 	private final FeedSubscriptionDAO feedSubscriptionDAO;
 	private final CacheService cache;
 
-	private FeedRefreshExecutor pool;
-	private Striped<Lock> locks;
+	private final FeedRefreshExecutor pool;
+	private final Striped<Lock> locks;
 
-	private Meter entryCacheMiss;
-	private Meter entryCacheHit;
-	private Meter feedUpdated;
-	private Meter entryInserted;
+	private final Meter entryCacheMiss;
+	private final Meter entryCacheHit;
+	private final Meter feedUpdated;
+	private final Meter entryInserted;
 
 	@Inject
 	public FeedRefreshUpdater(SessionFactory sessionFactory, FeedUpdateService feedUpdateService, PubSubService pubSubService,
@@ -94,70 +94,6 @@ public class FeedRefreshUpdater implements Managed {
 		pool.execute(new EntryTask(context));
 	}
 
-	private class EntryTask implements Task {
-
-		private FeedRefreshContext context;
-
-		public EntryTask(FeedRefreshContext context) {
-			this.context = context;
-		}
-
-		@Override
-		public void run() {
-			boolean ok = true;
-			final Feed feed = context.getFeed();
-			List<FeedEntry> entries = context.getEntries();
-			if (entries.isEmpty()) {
-				feed.setMessage("Feed has no entries");
-			} else {
-				List<String> lastEntries = cache.getLastEntries(feed);
-				List<String> currentEntries = new ArrayList<>();
-
-				List<FeedSubscription> subscriptions = null;
-				for (FeedEntry entry : entries) {
-					String cacheKey = cache.buildUniqueEntryKey(feed, entry);
-					if (!lastEntries.contains(cacheKey)) {
-						log.debug("cache miss for {}", entry.getUrl());
-						if (subscriptions == null) {
-							subscriptions = UnitOfWork.call(sessionFactory, () -> feedSubscriptionDAO.findByFeed(feed));
-						}
-						ok &= addEntry(feed, entry, subscriptions);
-						entryCacheMiss.mark();
-					} else {
-						log.debug("cache hit for {}", entry.getUrl());
-						entryCacheHit.mark();
-					}
-
-					currentEntries.add(cacheKey);
-				}
-				cache.setLastEntries(feed, currentEntries);
-
-				if (subscriptions == null) {
-					feed.setMessage("No new entries found");
-				} else if (!subscriptions.isEmpty()) {
-					List<User> users = subscriptions.stream().map(s -> s.getUser()).collect(Collectors.toList());
-					cache.invalidateUnreadCount(subscriptions.toArray(new FeedSubscription[0]));
-					cache.invalidateUserRootCategory(users.toArray(new User[0]));
-				}
-			}
-
-			if (config.getApplicationSettings().getPubsubhubbub()) {
-				handlePubSub(feed);
-			}
-			if (!ok) {
-				// requeue asap
-				feed.setDisabledUntil(new Date(0));
-			}
-			feedUpdated.mark();
-			queues.giveBack(feed);
-		}
-
-		@Override
-		public boolean isUrgent() {
-			return context.isUrgent();
-		}
-	}
-
 	private boolean addEntry(final Feed feed, final FeedEntry entry, final List<FeedSubscription> subscriptions) {
 		boolean success = false;
 
@@ -223,4 +159,68 @@ public class FeedRefreshUpdater implements Managed {
 		}
 	}
 
+	private class EntryTask implements Task {
+
+		private final FeedRefreshContext context;
+
+		public EntryTask(FeedRefreshContext context) {
+			this.context = context;
+		}
+
+		@Override
+		public void run() {
+			boolean ok = true;
+			final Feed feed = context.getFeed();
+			List<FeedEntry> entries = context.getEntries();
+			if (entries.isEmpty()) {
+				feed.setMessage("Feed has no entries");
+			} else {
+				List<String> lastEntries = cache.getLastEntries(feed);
+				List<String> currentEntries = new ArrayList<>();
+
+				List<FeedSubscription> subscriptions = null;
+				for (FeedEntry entry : entries) {
+					String cacheKey = cache.buildUniqueEntryKey(feed, entry);
+					if (!lastEntries.contains(cacheKey)) {
+						log.debug("cache miss for {}", entry.getUrl());
+						if (subscriptions == null) {
+							subscriptions = UnitOfWork.call(sessionFactory, () -> feedSubscriptionDAO.findByFeed(feed));
+						}
+						ok &= addEntry(feed, entry, subscriptions);
+						entryCacheMiss.mark();
+					} else {
+						log.debug("cache hit for {}", entry.getUrl());
+						entryCacheHit.mark();
+					}
+
+					currentEntries.add(cacheKey);
+				}
+				cache.setLastEntries(feed, currentEntries);
+
+				if (subscriptions == null) {
+					feed.setMessage("No new entries found");
+				} else if (!subscriptions.isEmpty()) {
+					List<User> users = subscriptions.stream().map(FeedSubscription::getUser).collect(Collectors.toList());
+					cache.invalidateUnreadCount(subscriptions.toArray(new FeedSubscription[0]));
+					cache.invalidateUserRootCategory(users.toArray(new User[0]));
+				}
+			}
+
+			if (config.getApplicationSettings().getPubsubhubbub()) {
+				handlePubSub(feed);
+			}
+			if (!ok) {
+				// requeue asap
+				feed.setDisabledUntil(new Date(0));
+			}
+			feedUpdated.mark();
+			queues.giveBack(feed);
+		}
+
+		@Override
+		public boolean isUrgent() {
+			return context.isUrgent();
+		}
+	}
+
 }

src/main/java/com/commafeed/backend/feed/FeedRefreshWorker.java

@@ -1,7 +1,5 @@
 package com.commafeed.backend.feed;
 
-import io.dropwizard.lifecycle.Managed;
-
 import java.util.Date;
 import java.util.List;
 import java.util.Optional;
@@ -10,8 +8,6 @@ import java.util.stream.Collectors;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.codec.digest.DigestUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.time.DateUtils;
@@ -23,6 +19,9 @@ import com.commafeed.backend.feed.FeedRefreshExecutor.Task;
 import com.commafeed.backend.model.Feed;
 import com.commafeed.backend.model.FeedEntry;
 
+import io.dropwizard.lifecycle.Managed;
+import lombok.extern.slf4j.Slf4j;
+
 /**
  * Calls {@link FeedFetcher} and handles its outcome
  * 
@@ -61,25 +60,6 @@ public class FeedRefreshWorker implements Managed {
 		pool.execute(new FeedTask(context));
 	}
 
-	private class FeedTask implements Task {
-
-		private FeedRefreshContext context;
-
-		public FeedTask(FeedRefreshContext context) {
-			this.context = context;
-		}
-
-		@Override
-		public void run() {
-			update(context);
-		}
-
-		@Override
-		public boolean isUrgent() {
-			return context.isUrgent();
-		}
-	}
-
 	private void update(FeedRefreshContext context) {
 		Feed feed = context.getFeed();
 		int refreshInterval = config.getApplicationSettings().getRefreshIntervalMinutes();
@@ -97,8 +77,8 @@ public class FeedRefreshWorker implements Managed {
 			}
 
 			if (config.getApplicationSettings().getHeavyLoad()) {
-				disabledUntil = FeedUtils.buildDisabledUntil(fetchedFeed.getFeed().getLastEntryDate(), fetchedFeed.getFeed()
-						.getAverageEntryInterval(), disabledUntil);
+				disabledUntil = FeedUtils.buildDisabledUntil(fetchedFeed.getFeed().getLastEntryDate(),
+						fetchedFeed.getFeed().getAverageEntryInterval(), disabledUntil);
 			}
 			String urlAfterRedirect = fetchedFeed.getUrlAfterRedirect();
 			if (StringUtils.equals(url, urlAfterRedirect)) {
@@ -156,7 +136,7 @@ public class FeedRefreshWorker implements Managed {
 				topic = "http://" + topic;
 			} else if (topic.startsWith("feed://")) {
 				topic = "http://" + topic.substring(7);
-			} else if (topic.startsWith("http") == false) {
+			} else if (!topic.startsWith("http")) {
 				topic = "http://" + topic;
 			}
 			log.debug("feed {} has pubsub info: {}", feed.getUrl(), topic);
@@ -165,4 +145,23 @@ public class FeedRefreshWorker implements Managed {
 			feed.setPushTopicHash(DigestUtils.sha1Hex(topic));
 		}
 	}
+
+	private class FeedTask implements Task {
+
+		private final FeedRefreshContext context;
+
+		public FeedTask(FeedRefreshContext context) {
+			this.context = context;
+		}
+
+		@Override
+		public void run() {
+			update(context);
+		}
+
+		@Override
+		public boolean isUrgent() {
+			return context.isUrgent();
+		}
+	}
 }

src/main/java/com/commafeed/backend/feed/FeedUtils.java

@@ -110,7 +110,7 @@ public class FeedUtils {
 	public static Charset guessEncoding(byte[] bytes) {
 		String extracted = extractDeclaredEncoding(bytes);
 		if (StringUtils.startsWithIgnoreCase(extracted, "iso-8859-")) {
-			if (StringUtils.endsWith(extracted, "1") == false) {
+			if (!StringUtils.endsWith(extracted, "1")) {
 				return Charset.forName(extracted);
 			}
 		} else if (StringUtils.startsWithIgnoreCase(extracted, "windows-")) {

src/main/java/com/commafeed/backend/feed/FetchedFeed.java

@@ -3,12 +3,12 @@ package com.commafeed.backend.feed;
 import java.util.ArrayList;
 import java.util.List;
 
-import lombok.Getter;
-import lombok.Setter;
-
 import com.commafeed.backend.model.Feed;
 import com.commafeed.backend.model.FeedEntry;
 
+import lombok.Getter;
+import lombok.Setter;
+
 @Getter
 @Setter
 public class FetchedFeed {

src/main/java/com/commafeed/backend/model/User.java

@@ -8,11 +8,11 @@ import javax.persistence.Table;
 import javax.persistence.Temporal;
 import javax.persistence.TemporalType;
 
+import org.apache.commons.lang3.time.DateUtils;
+
 import lombok.Getter;
 import lombok.Setter;
 
-import org.apache.commons.lang3.time.DateUtils;
-
 @Entity
 @Table(name = "USERS")
 @SuppressWarnings("serial")
@@ -55,7 +55,7 @@ public class User extends AbstractModel {
 	private Date lastFullRefresh;
 
 	public boolean shouldRefreshFeedsAt(Date when) {
-		return (lastFullRefresh == null || lastFullRefreshMoreThan30MinutesBefore(when));
+		return lastFullRefresh == null || lastFullRefreshMoreThan30MinutesBefore(when);
 	}
 
 	private boolean lastFullRefreshMoreThan30MinutesBefore(Date when) {

src/main/java/com/commafeed/backend/model/UserRole.java

@@ -19,7 +19,7 @@ import lombok.Setter;
 @Setter
 public class UserRole extends AbstractModel {
 
-	public static enum Role {
+	public enum Role {
 		USER, ADMIN
 	}
 

src/main/java/com/commafeed/backend/opml/OPMLImporter.java

@@ -6,9 +6,6 @@ import java.util.List;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.collections4.CollectionUtils;
 import org.apache.commons.lang3.StringUtils;
 
@@ -23,6 +20,9 @@ import com.rometools.opml.feed.opml.Opml;
 import com.rometools.opml.feed.opml.Outline;
 import com.rometools.rome.io.WireFeedInput;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 @Slf4j
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton

src/main/java/com/commafeed/backend/service/DatabaseCleaningService.java

@@ -24,7 +24,7 @@ import lombok.extern.slf4j.Slf4j;
  * 
  */
 @Slf4j
-@RequiredArgsConstructor(onConstructor = @__({ @Inject }) )
+@RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class DatabaseCleaningService {
 

src/main/java/com/commafeed/backend/service/FeedEntryFilteringService.java

@@ -12,8 +12,6 @@ import java.util.concurrent.TimeoutException;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import org.apache.commons.jexl2.JexlContext;
 import org.apache.commons.jexl2.JexlEngine;
 import org.apache.commons.jexl2.JexlException;
@@ -30,12 +28,16 @@ import org.jsoup.Jsoup;
 
 import com.commafeed.backend.model.FeedEntry;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class FeedEntryFilteringService {
 
 	private static final JexlEngine ENGINE = initEngine();
 
+	private final ExecutorService executor = Executors.newCachedThreadPool();
+
 	private static JexlEngine initEngine() {
 		// classloader that prevents object creation
 		ClassLoader cl = new ClassLoader() {
@@ -70,8 +72,6 @@ public class FeedEntryFilteringService {
 		return engine;
 	}
 
-	private ExecutorService executor = Executors.newCachedThreadPool();
-
 	public boolean filterMatchesEntry(String filter, FeedEntry entry) throws FeedEntryFilterException {
 		if (StringUtils.isBlank(filter)) {
 			return true;
@@ -87,8 +87,8 @@ public class FeedEntryFilteringService {
 		JexlContext context = new MapContext();
 		context.set("title", entry.getContent().getTitle() == null ? "" : Jsoup.parse(entry.getContent().getTitle()).text().toLowerCase());
 		context.set("author", entry.getContent().getAuthor() == null ? "" : entry.getContent().getAuthor().toLowerCase());
-		context.set("content", entry.getContent().getContent() == null ? "" : Jsoup.parse(entry.getContent().getContent()).text()
-				.toLowerCase());
+		context.set("content",
+				entry.getContent().getContent() == null ? "" : Jsoup.parse(entry.getContent().getContent()).text().toLowerCase());
 		context.set("url", entry.getUrl() == null ? "" : entry.getUrl().toLowerCase());
 		context.set("categories", entry.getContent().getCategories() == null ? "" : entry.getContent().getCategories().toLowerCase());
 

src/main/java/com/commafeed/backend/service/FeedEntryService.java

@@ -7,8 +7,6 @@ import java.util.List;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.backend.cache.CacheService;
 import com.commafeed.backend.dao.FeedEntryDAO;
 import com.commafeed.backend.dao.FeedEntryStatusDAO;
@@ -19,6 +17,8 @@ import com.commafeed.backend.model.FeedEntryStatus;
 import com.commafeed.backend.model.FeedSubscription;
 import com.commafeed.backend.model.User;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class FeedEntryService {

src/main/java/com/commafeed/backend/service/FeedEntryTagService.java

@@ -7,14 +7,14 @@ import java.util.stream.Collectors;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.backend.dao.FeedEntryDAO;
 import com.commafeed.backend.dao.FeedEntryTagDAO;
 import com.commafeed.backend.model.FeedEntry;
 import com.commafeed.backend.model.FeedEntryTag;
 import com.commafeed.backend.model.User;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class FeedEntryTagService {
@@ -29,10 +29,12 @@ public class FeedEntryTagService {
 		}
 
 		List<FeedEntryTag> existingTags = feedEntryTagDAO.findByEntry(user, entry);
-		Set<String> existingTagNames = existingTags.stream().map(t -> t.getName()).collect(Collectors.toSet());
+		Set<String> existingTagNames = existingTags.stream().map(FeedEntryTag::getName).collect(Collectors.toSet());
 
-		List<FeedEntryTag> addList = tagNames.stream().filter(name -> !existingTagNames.contains(name))
-				.map(name -> new FeedEntryTag(user, entry, name)).collect(Collectors.toList());
+		List<FeedEntryTag> addList = tagNames.stream()
+				.filter(name -> !existingTagNames.contains(name))
+				.map(name -> new FeedEntryTag(user, entry, name))
+				.collect(Collectors.toList());
 		List<FeedEntryTag> removeList = existingTags.stream().filter(tag -> !tagNames.contains(tag.getName())).collect(Collectors.toList());
 
 		feedEntryTagDAO.saveOrUpdate(addList);

src/main/java/com/commafeed/backend/service/FeedSubscriptionService.java

@@ -7,9 +7,6 @@ import java.util.stream.Collectors;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.lang3.StringUtils;
 
 import com.commafeed.CommaFeedConfiguration;
@@ -26,18 +23,14 @@ import com.commafeed.backend.model.Models;
 import com.commafeed.backend.model.User;
 import com.commafeed.frontend.model.UnreadCount;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 @Slf4j
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class FeedSubscriptionService {
 
-	@SuppressWarnings("serial")
-	public static class FeedSubscriptionException extends RuntimeException {
-		private FeedSubscriptionException(String msg) {
-			super(msg);
-		}
-	}
-
 	private final FeedDAO feedDAO;
 	private final FeedEntryStatusDAO feedEntryStatusDAO;
 	private final FeedSubscriptionDAO feedSubscriptionDAO;
@@ -108,7 +101,7 @@ public class FeedSubscriptionService {
 	}
 
 	public Map<Long, UnreadCount> getUnreadCount(User user) {
-		return feedSubscriptionDAO.findAll(user).stream().collect(Collectors.toMap(s -> s.getId(), s -> getUnreadCount(user, s)));
+		return feedSubscriptionDAO.findAll(user).stream().collect(Collectors.toMap(FeedSubscription::getId, s -> getUnreadCount(user, s)));
 	}
 
 	private UnreadCount getUnreadCount(User user, FeedSubscription sub) {
@@ -121,4 +114,11 @@ public class FeedSubscriptionService {
 		return count;
 	}
 
+	@SuppressWarnings("serial")
+	public static class FeedSubscriptionException extends RuntimeException {
+		private FeedSubscriptionException(String msg) {
+			super(msg);
+		}
+	}
+
 }

src/main/java/com/commafeed/backend/service/FeedUpdateService.java

@@ -6,9 +6,6 @@ import java.util.List;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.codec.digest.DigestUtils;
 
 import com.commafeed.backend.dao.FeedEntryDAO;
@@ -20,6 +17,9 @@ import com.commafeed.backend.model.FeedEntryStatus;
 import com.commafeed.backend.model.FeedSubscription;
 import com.commafeed.backend.service.FeedEntryFilteringService.FeedEntryFilterException;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 @Slf4j
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton

src/main/java/com/commafeed/backend/service/MailService.java

@@ -13,12 +13,12 @@ import javax.mail.Transport;
 import javax.mail.internet.InternetAddress;
 import javax.mail.internet.MimeMessage;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.CommaFeedConfiguration;
 import com.commafeed.CommaFeedConfiguration.ApplicationSettings;
 import com.commafeed.backend.model.User;
 
+import lombok.RequiredArgsConstructor;
+
 /**
  * Mailing service
  * 

src/main/java/com/commafeed/backend/service/PasswordEncryptionService.java

@@ -12,11 +12,11 @@ import javax.crypto.spec.PBEKeySpec;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
+import org.apache.commons.lang3.StringUtils;
+
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 
-import org.apache.commons.lang3.StringUtils;
-
 // taken from http://www.javacodegeeks.com/2012/05/secure-password-storage-donts-dos-and.html
 @SuppressWarnings("serial")
 @Slf4j

src/main/java/com/commafeed/backend/service/PubSubService.java

@@ -7,9 +7,6 @@ import javax.inject.Inject;
 import javax.inject.Singleton;
 import javax.ws.rs.core.MediaType;
 
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.http.HttpHeaders;
@@ -28,6 +25,9 @@ import com.commafeed.backend.feed.FeedUtils;
 import com.commafeed.backend.model.Feed;
 import com.commafeed.frontend.resource.PubSubHubbubCallbackREST;
 
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
 /**
  * Sends push subscription requests. Callback is handled by {@link PubSubHubbubCallbackREST}
  * 
@@ -76,8 +76,8 @@ public class PubSubService {
 					queues.giveBack(feed);
 					log.debug("handled pushpress subfeed {} : {}", topic, feed.getPushTopic());
 				} else {
-					throw new Exception("Unexpected response code: " + code + " " + response.getStatusLine().getReasonPhrase() + " - "
-							+ message);
+					throw new Exception(
+							"Unexpected response code: " + code + " " + response.getStatusLine().getReasonPhrase() + " - " + message);
 				}
 			}
 			log.debug("subscribed to {} for {}", hub, topic);

src/main/java/com/commafeed/backend/service/UserService.java

@@ -9,8 +9,6 @@ import java.util.UUID;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import org.apache.commons.codec.digest.DigestUtils;
 import org.apache.commons.lang3.StringUtils;
 
@@ -26,6 +24,8 @@ import com.commafeed.backend.model.UserRole.Role;
 import com.commafeed.backend.service.internal.PostLoginActivities;
 import com.google.common.base.Preconditions;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class UserService {
@@ -102,8 +102,8 @@ public class UserService {
 
 			Preconditions.checkNotNull(email);
 			Preconditions.checkArgument(StringUtils.length(name) >= 3, "Name too short (3 characters minimum)");
-			Preconditions
-					.checkArgument(forceRegistration || StringUtils.length(password) >= 6, "Password too short (6 characters maximum)");
+			Preconditions.checkArgument(forceRegistration || StringUtils.length(password) >= 6,
+					"Password too short (6 characters maximum)");
 			Preconditions.checkArgument(StringUtils.contains(email, "@"), "Invalid email address");
 		}
 

src/main/java/com/commafeed/backend/service/internal/PostLoginActivities.java

@@ -5,8 +5,6 @@ import java.util.Date;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import org.apache.commons.lang3.time.DateUtils;
 
 import com.commafeed.CommaFeedConfiguration;
@@ -14,6 +12,8 @@ import com.commafeed.backend.dao.UserDAO;
 import com.commafeed.backend.model.User;
 import com.commafeed.backend.service.FeedSubscriptionService;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class PostLoginActivities {

src/main/java/com/commafeed/backend/task/OldEntriesCleanupTask.java

@@ -5,11 +5,11 @@ import java.util.concurrent.TimeUnit;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.CommaFeedConfiguration;
 import com.commafeed.backend.service.DatabaseCleaningService;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class OldEntriesCleanupTask extends ScheduledTask {

src/main/java/com/commafeed/backend/task/OldStatusesCleanupTask.java

@@ -6,11 +6,11 @@ import java.util.concurrent.TimeUnit;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.CommaFeedConfiguration;
 import com.commafeed.backend.service.DatabaseCleaningService;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class OldStatusesCleanupTask extends ScheduledTask {

src/main/java/com/commafeed/backend/task/OrphanedContentsCleanupTask.java

@@ -5,10 +5,10 @@ import java.util.concurrent.TimeUnit;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.backend.service.DatabaseCleaningService;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class OrphanedContentsCleanupTask extends ScheduledTask {

src/main/java/com/commafeed/backend/task/OrphanedFeedsCleanupTask.java

@@ -5,10 +5,10 @@ import java.util.concurrent.TimeUnit;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import lombok.RequiredArgsConstructor;
-
 import com.commafeed.backend.service.DatabaseCleaningService;
 
+import lombok.RequiredArgsConstructor;
+
 @RequiredArgsConstructor(onConstructor = @__({ @Inject }))
 @Singleton
 public class OrphanedFeedsCleanupTask extends ScheduledTask {