From a858380121887dd393c61732590023d95e3c60b2 Mon Sep 17 00:00:00 2001 From: Athou Date: Fri, 23 Jan 2026 08:33:52 +0100 Subject: [PATCH] cleanup --- commafeed-client/src/App.tsx | 4 ++++ .../commafeed/backend/service/PasswordEncryptionService.java | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/commafeed-client/src/App.tsx b/commafeed-client/src/App.tsx index 7ee58767..560b2242 100644 --- a/commafeed-client/src/App.tsx +++ b/commafeed-client/src/App.tsx @@ -195,6 +195,8 @@ function CustomJsHandler() { document.body.appendChild(script) setScriptLoaded(true) + + return () => script.remove() }, [scriptLoaded, loading]) return null @@ -207,6 +209,8 @@ function CustomCssHandler() { link.type = "text/css" link.href = "custom_css.css" document.head.appendChild(link) + + return () => link.remove() }, []) return null diff --git a/commafeed-server/src/main/java/com/commafeed/backend/service/PasswordEncryptionService.java b/commafeed-server/src/main/java/com/commafeed/backend/service/PasswordEncryptionService.java index b55a9909..2e473da3 100644 --- a/commafeed-server/src/main/java/com/commafeed/backend/service/PasswordEncryptionService.java +++ b/commafeed-server/src/main/java/com/commafeed/backend/service/PasswordEncryptionService.java @@ -1,6 +1,5 @@ package com.commafeed.backend.service; -import java.io.Serializable; import java.security.MessageDigest; import java.security.NoSuchAlgorithmException; import java.security.SecureRandom; @@ -18,11 +17,10 @@ import lombok.RequiredArgsConstructor; import lombok.extern.slf4j.Slf4j; // taken from http://www.javacodegeeks.com/2012/05/secure-password-storage-donts-dos-and.html -@SuppressWarnings("serial") @Slf4j @RequiredArgsConstructor @Singleton -public class PasswordEncryptionService implements Serializable { +public class PasswordEncryptionService { public boolean authenticate(String attemptedPassword, byte[] encryptedPassword, byte[] salt) { if (StringUtils.isBlank(attemptedPassword)) {