From 6c68fda5725b959c0341a9b2cbee10132d0b5711 Mon Sep 17 00:00:00 2001 From: Athou Date: Sun, 25 Jan 2026 10:45:21 +0100 Subject: [PATCH] make "disable pull to refresh" false by default (#2030) --- .../components/settings/DisplaySettings.tsx | 82 +++++++++---------- .../commafeed/frontend/resource/UserREST.java | 2 +- 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/commafeed-client/src/components/settings/DisplaySettings.tsx b/commafeed-client/src/components/settings/DisplaySettings.tsx index b49b3ba2..e9d42219 100644 --- a/commafeed-client/src/components/settings/DisplaySettings.tsx +++ b/commafeed-client/src/components/settings/DisplaySettings.tsx @@ -143,6 +143,47 @@ export function DisplaySettings() { onChange={async e => await dispatch(changeMobileFooter(e.currentTarget.checked))} /> + Scrolling} labelPosition="center" /> + + Disable "Pull to refresh" browser behavior} + description={This setting can cause scrolling issues on some browsers (e.g. Safari)} + checked={disablePullToRefresh} + onChange={async e => await dispatch(changeDisablePullToRefresh(e.currentTarget.checked))} + /> + + Scroll selected entry to the top of the page} + value={scrollMode} + onChange={async value => await dispatch(changeScrollMode(value as ScrollMode))} + > + + {Object.entries(scrollModeOptions).map(e => ( + + ))} + + + + Entries to keep above the selected entry when scrolling} + description={Only applies to compact, cozy and detailed modes} + min={0} + value={entriesToKeepOnTop} + onChange={async value => await dispatch(changeEntriesToKeepOnTopWhenScrolling(+value))} + /> + + Scroll smoothly when navigating between entries} + checked={scrollSpeed ? scrollSpeed > 0 : false} + onChange={async e => await dispatch(changeScrollSpeed(e.currentTarget.checked))} + /> + + In expanded view, scrolling through entries mark them as read} + checked={scrollMarks} + onChange={async e => await dispatch(changeScrollMarks(e.currentTarget.checked))} + /> + Browser tab} labelPosition="center" /> await dispatch(changeCustomContextMenu(e.currentTarget.checked))} /> - Scrolling} labelPosition="center" /> - - Scroll selected entry to the top of the page} - value={scrollMode} - onChange={async value => await dispatch(changeScrollMode(value as ScrollMode))} - > - - {Object.entries(scrollModeOptions).map(e => ( - - ))} - - - - Entries to keep above the selected entry when scrolling} - description={Only applies to compact, cozy and detailed modes} - min={0} - value={entriesToKeepOnTop} - onChange={async value => await dispatch(changeEntriesToKeepOnTopWhenScrolling(+value))} - /> - - Scroll smoothly when navigating between entries} - checked={scrollSpeed ? scrollSpeed > 0 : false} - onChange={async e => await dispatch(changeScrollSpeed(e.currentTarget.checked))} - /> - - In expanded view, scrolling through entries mark them as read} - checked={scrollMarks} - onChange={async e => await dispatch(changeScrollMarks(e.currentTarget.checked))} - /> - - Disable "Pull to refresh" browser behavior} - description={This setting can cause scrolling issues on some browsers (e.g. Safari)} - checked={disablePullToRefresh} - onChange={async e => await dispatch(changeDisablePullToRefresh(e.currentTarget.checked))} - /> - Sharing sites} labelPosition="center" /> diff --git a/commafeed-server/src/main/java/com/commafeed/frontend/resource/UserREST.java b/commafeed-server/src/main/java/com/commafeed/frontend/resource/UserREST.java index 71f28b28..8afcde4e 100644 --- a/commafeed-server/src/main/java/com/commafeed/frontend/resource/UserREST.java +++ b/commafeed-server/src/main/java/com/commafeed/frontend/resource/UserREST.java @@ -151,7 +151,7 @@ public class UserREST { s.setMobileFooter(false); s.setUnreadCountTitle(false); s.setUnreadCountFavicon(true); - s.setDisablePullToRefresh(true); + s.setDisablePullToRefresh(false); } return s; }