From 5e92f9ffb8c8ecd906988edf7fa6381d1484087a Mon Sep 17 00:00:00 2001
From: Athou <jeremiepanzer@gmail.com>
Date: Sun, 19 Jan 2025 21:40:30 +0100
Subject: [PATCH] we can skip the docker step altogether for PRs

---
 .github/workflows/ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 16f3970f..21ad1e95 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -59,8 +59,9 @@ jobs:
           path: commafeed-server/target/commafeed-*-runner*
 
   docker:
-    needs: build
     runs-on: ubuntu-latest
+    needs: build
+    if: ${{ github.ref_type == 'tag' || github.ref_name == 'master' }}
 
     strategy:
       matrix:
@@ -107,7 +108,6 @@ jobs:
       # Docker
       - name: Login to Container Registry
         uses: docker/login-action@v3
-        if: ${{ github.ref_type == 'tag' || github.ref_name == 'master' }}
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}