Extollo/extollo
2
0
Fork 0
Code Issues 11 Pull Requests Projects 1 Releases Activity

CI - Need way for extollo modules to install from master branch #4

New Issue
Closed
opened 2021-03-31 03:01:16 +00:00 by garrettmills · 1 comment
garrettmills commented 2021-03-31 03:01:16 +00:00
Owner
Copy Link

When building modules in CI, they pull the latest versioned release rather than the master branch of the module. This can lead to build errors when the module has changed on master, but not the version.

Idea would be to add a prepare script to package.json for all of the modules by default that builds them on install. Then, when other modules install them, they install from the git repo.

When we do a release, we replace the git references with actual release versions.

When building modules in CI, they pull the latest versioned release rather than the master branch of the module. This can lead to build errors when the module has changed on master, but not the version. Idea would be to add a `prepare` script to `package.json` for all of the modules by default that builds them on install. Then, when other modules install them, they install from the git repo. When we do a release, we replace the git references with actual release versions.
garrettmills added the
bug
CI
 labels 2021-03-31 03:01:16 +00:00
garrettmills added this to the Initial Release project 2021-03-31 03:01:16 +00:00
garrettmills commented 2021-03-31 03:40:05 +00:00
Author
Owner
Copy Link

Should be resolved for now. Will need to create a doc for doing a release properly when the time comes.

Should be resolved for now. Will need to create a doc for doing a release properly when the time comes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
CI

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
@extollo/cli

   
@extollo/di

   
@extollo/i18n

   
@extollo/lib

   
@extollo/orm

   
@extollo/util

   
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
CI
duplicate
enhancement
@extollo/cli
@extollo/di
@extollo/i18n
@extollo/lib
@extollo/orm
@extollo/util
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Initial Release
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extollo/extollo#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?