diff --git a/app/ldap/controllers/Users.controller.js b/app/ldap/controllers/Users.controller.js index cc5a9f7..a4abf31 100644 --- a/app/ldap/controllers/Users.controller.js +++ b/app/ldap/controllers/Users.controller.js @@ -218,10 +218,12 @@ class UsersController extends LDAPController { // TODO flitter-orm chunk query // TODO generalize scoped search logic async search_people(req, res, next) { - if ( !req.user.can('ldap:search:users') ) { + if ( !req.user.can('ldap:search:users:me') ) { return next(new LDAP.InsufficientAccessRightsError()) } + const can_search_all = req.user.can('ldap:search:users') + const iam_targets = this.parse_iam_targets(req.filter) if ( req.scope === 'base' ) { // If scope is base, check if the base DN matches the filter. @@ -231,7 +233,12 @@ class UsersController extends LDAPController { const user = await this.get_resource_from_dn(req.dn) // Make sure the user is ldap visible && match the filter - if ( user && user.ldap_visible && req.filter.matches(await user.to_ldap(iam_targets)) ) { + if ( + user + && user.ldap_visible + && req.filter.matches(await user.to_ldap(iam_targets)) + && (req.user.id === user.id || can_search_all) + ) { // If so, send the object res.send({ @@ -255,6 +262,7 @@ class UsersController extends LDAPController { // Fetch the LDAP-visible users const users = await this.User.ldap_directory() for ( const user of users ) { + if ( user.id !== req.user.id && !can_search_all ) continue // Make sure the user os of the appropriate scope if ( req.dn.equals(user.dn) || user.dn.parent().equals(req.dn) ) { @@ -283,6 +291,7 @@ class UsersController extends LDAPController { this.output.debug(`Filter:`) this.output.debug(this.filter_to_obj(req.filter.json)) for ( const user of users ) { + if ( user.id !== req.user.id && !can_search_all ) continue this.output.debug(`Checking ${user.uid}...`) this.output.debug(`DN: ${user.dn}`) this.output.debug(`Req DN equals: ${req.dn.equals(user.dn)}`) diff --git a/config/auth.config.js b/config/auth.config.js index eee02bf..34269da 100644 --- a/config/auth.config.js +++ b/config/auth.config.js @@ -194,6 +194,7 @@ const auth_config = { // LDAP Binding 'ldap:bind', + 'ldap:search:users:me', ], root: ['v1', 'ldap', 'saml', 'profile', 'oauth', 'app', 'auth', 'iam'],