From ad6e3c3b92cc98e783c3207e3737a52797653eb0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=94=D0=B0=D0=BD=D0=B8=D1=97=D0=BB=20=D0=93=D1=80=D0=B8?= =?UTF-8?q?=D0=B3=D0=BE=D1=80=27=D1=94=D0=B2?= Date: Fri, 26 Jul 2024 18:59:55 +0300 Subject: [PATCH] Fix Vector#equalsEpsilon ignoring parameter Provided epsilon parameter was used for Y axis but ignored for X axis. Some useless return statements are also removed. --- src/js/core/vector.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/js/core/vector.js b/src/js/core/vector.js index 50fa9433..9525f5b3 100644 --- a/src/js/core/vector.js +++ b/src/js/core/vector.js @@ -489,7 +489,6 @@ export class Vector { } default: { assertAlways(false, "Invalid fast inplace rotation: " + angle); - return this; } } // return new Vector(this.x * cos - this.y * sin, this.x * sin + this.y * cos); @@ -519,7 +518,6 @@ export class Vector { } default: { assertAlways(false, "Invalid fast inplace rotation: " + angle); - return new Vector(); } } } @@ -593,7 +591,6 @@ export class Vector { } default: assertAlways(false, "Invalid angle: " + angle); - return; } } @@ -603,7 +600,7 @@ export class Vector { * @returns {Boolean} */ equalsEpsilon(v, epsilon = 1e-5) { - return Math.abs(this.x - v.x) < 1e-5 && Math.abs(this.y - v.y) < epsilon; + return Math.abs(this.x - v.x) < epsilon && Math.abs(this.y - v.y) < epsilon; } /**