From 64c48161948e2774b930e7a08a4418f198374768 Mon Sep 17 00:00:00 2001 From: tobspr Date: Sun, 28 Jun 2020 20:31:22 +0200 Subject: [PATCH] Remove some todos --- src/js/core/game_state.js | 2 -- src/js/game/entity_components.js | 3 --- src/js/game/entity_manager.js | 2 +- src/js/game/key_action_mapper.js | 1 - src/js/game/map.js | 1 - src/js/savegame/savegame_interface.js | 14 -------------- 6 files changed, 1 insertion(+), 22 deletions(-) diff --git a/src/js/core/game_state.js b/src/js/core/game_state.js index cd3cb677..cee962f5 100644 --- a/src/js/core/game_state.js +++ b/src/js/core/game_state.js @@ -134,8 +134,6 @@ export class GameState { */ cancelAllAsyncOperations() { this.asyncChannel.cancelAll(); - // TODO - // this.app.api.cancelRequests(); } //// CALLBACKS //// diff --git a/src/js/game/entity_components.js b/src/js/game/entity_components.js index fc29ce80..a4c7f438 100644 --- a/src/js/game/entity_components.js +++ b/src/js/game/entity_components.js @@ -20,9 +20,6 @@ import { WiredPinsComponent } from "./components/wired_pins"; */ export class EntityComponentStorage { constructor() { - // TODO: Figure out if its faster to declare all components here and not - // compile them out (In theory, should make it a fast object in V8 engine) - /* typehints:start */ /** @type {StaticMapEntityComponent} */ diff --git a/src/js/game/entity_manager.js b/src/js/game/entity_manager.js index c3c94fbc..11bc709c 100644 --- a/src/js/game/entity_manager.js +++ b/src/js/game/entity_manager.js @@ -9,7 +9,7 @@ const logger = createLogger("entity_manager"); // Manages all entities -// TODO & NOTICE: We use arrayDeleteValue instead of fastArrayDeleteValue since that does not preserve the order +// NOTICE: We use arrayDeleteValue instead of fastArrayDeleteValue since that does not preserve the order // This is slower but we need it for the street path generation export class EntityManager extends BasicSerializableObject { diff --git a/src/js/game/key_action_mapper.js b/src/js/game/key_action_mapper.js index 85e3842e..86abeef5 100644 --- a/src/js/game/key_action_mapper.js +++ b/src/js/game/key_action_mapper.js @@ -243,7 +243,6 @@ export function getStringForKeyCode(code) { return "'"; } - // TODO return String.fromCharCode(code); } diff --git a/src/js/game/map.js b/src/js/game/map.js index bb669c54..ec8d1ce3 100644 --- a/src/js/game/map.js +++ b/src/js/game/map.js @@ -43,7 +43,6 @@ export class BaseMap extends BasicSerializableObject { * @param {number} chunkY */ getChunk(chunkX, chunkY, createIfNotExistent = false) { - // TODO: Better generation const chunkIdentifier = chunkX + "|" + chunkY; let storedChunk; diff --git a/src/js/savegame/savegame_interface.js b/src/js/savegame/savegame_interface.js index 8671471d..55fd27e7 100644 --- a/src/js/savegame/savegame_interface.js +++ b/src/js/savegame/savegame_interface.js @@ -90,18 +90,4 @@ export class BaseSavegameInterface { readIngameTimeSeconds() { return this.data.dump.time.timeSeconds; } - - /** - - - //////// ANTICHEAT /////// - - /** - * Detects cheats in the savegame - returns false if the game looks cheated - */ - performAnticheatCheck() { - // TODO - - return true; - } }