From 519128a70aecabd1753cb7dc660b6213c0085356 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=94=D0=B0=D0=BD=D0=B8=D1=97=D0=BB=20=D0=93=D1=80=D0=B8?=
 =?UTF-8?q?=D0=B3=D0=BE=D1=80=27=D1=94=D0=B2?= <dengr1065@gmail.com>
Date: Tue, 8 Apr 2025 16:59:40 +0300
Subject: [PATCH] Remove savegame stats (achievements data)

No longer used as achievements are gone.

Also, avoid copying the old savegame dump object. This is possible
thanks to this change.
---
 src/js/savegame/savegame.js          | 15 +--------------
 src/js/savegame/savegame_typedefs.js |  7 -------
 src/js/savegame/schemas/1008.js      | 11 +----------
 3 files changed, 2 insertions(+), 31 deletions(-)

diff --git a/src/js/savegame/savegame.js b/src/js/savegame/savegame.js
index 2502cb46..d93c5997 100644
--- a/src/js/savegame/savegame.js
+++ b/src/js/savegame/savegame.js
@@ -24,7 +24,6 @@ const logger = createLogger("savegame");
  * @typedef {import("../game/root").GameRoot} GameRoot
  * @typedef {import("./savegame_typedefs").SavegameData} SavegameData
  * @typedef {import("./savegame_typedefs").SavegameMetadata} SavegameMetadata
- * @typedef {import("./savegame_typedefs").SavegameStats} SavegameStats
  * @typedef {import("./savegame_typedefs").SerializedGame} SerializedGame
  */
 
@@ -99,11 +98,6 @@ export class Savegame extends ReadWriteProxy {
         return {
             version: this.getCurrentVersion(),
             dump: null,
-            stats: {
-                failedMam: false,
-                trashedCount: 0,
-                usedInverseRotator: false,
-            },
             lastUpdate: Date.now(),
             mods: MODS.getModsListForSavegame(),
         };
@@ -196,13 +190,6 @@ export class Savegame extends ReadWriteProxy {
     isSaveable() {
         return true;
     }
-    /**
-     * Returns the statistics of the savegame
-     * @returns {SavegameStats}
-     */
-    getStatistics() {
-        return this.currentData.stats;
-    }
 
     /**
      * Returns the *real* last update of the savegame, not the one of the metadata
@@ -273,7 +260,7 @@ export class Savegame extends ReadWriteProxy {
             return false;
         }
 
-        const shadowData = Object.assign({}, this.currentData);
+        const shadowData = {};
         shadowData.dump = dump;
         shadowData.lastUpdate = new Date().getTime();
         shadowData.version = this.getCurrentVersion();
diff --git a/src/js/savegame/savegame_typedefs.js b/src/js/savegame/savegame_typedefs.js
index 1a887e74..710ac68c 100644
--- a/src/js/savegame/savegame_typedefs.js
+++ b/src/js/savegame/savegame_typedefs.js
@@ -10,12 +10,6 @@
  * }[]} SavegameStoredMods
  *
  * @typedef {{
- *   failedMam: boolean,
- *   trashedCount: number,
- *   usedInverseRotator: boolean
- * }} SavegameStats
- *
- * @typedef {{
  *   camera: any,
  *   time: any,
  *   entityMgr: any,
@@ -32,7 +26,6 @@
  * @typedef {{
  *   version: number,
  *   dump: SerializedGame,
- *   stats: SavegameStats,
  *   lastUpdate: number,
  *   mods: SavegameStoredMods
  * }} SavegameData
diff --git a/src/js/savegame/schemas/1008.js b/src/js/savegame/schemas/1008.js
index 43c67ff4..227aa7b9 100644
--- a/src/js/savegame/schemas/1008.js
+++ b/src/js/savegame/schemas/1008.js
@@ -17,16 +17,7 @@ export class SavegameInterface_V1008 extends SavegameInterface_V1007 {
      * @param {import("../savegame_typedefs.js").SavegameData} data
      */
     static migrate1007to1008(data) {
+        // Note: no-op since achievement removal
         logger.log("Migrating 1007 to 1008");
-        const dump = data.dump;
-        if (!dump) {
-            return true;
-        }
-
-        Object.assign(data.stats, {
-            failedMam: true,
-            trashedCount: 0,
-            usedInverseRotator: true,
-        });
     }
 }