From 39e360cc5bb0f9dae45bbad0ade35e3c062ad5c1 Mon Sep 17 00:00:00 2001 From: EmeraldBlock <69981203+EmeraldBlock@users.noreply.github.com> Date: Thu, 8 Oct 2020 20:16:58 -0500 Subject: [PATCH] use safeModulo --- src/js/game/hud/parts/building_placer_logic.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/js/game/hud/parts/building_placer_logic.js b/src/js/game/hud/parts/building_placer_logic.js index cd189603..986db1b4 100644 --- a/src/js/game/hud/parts/building_placer_logic.js +++ b/src/js/game/hud/parts/building_placer_logic.js @@ -3,6 +3,7 @@ import { gMetaBuildingRegistry } from "../../../core/global_registries"; import { Signal, STOP_PROPAGATION } from "../../../core/signal"; import { TrackedState } from "../../../core/tracked_state"; import { Vector } from "../../../core/vector"; +import { safeModulo } from "../../../core/utils"; import { enumMouseButton } from "../../camera"; import { StaticMapEntityComponent } from "../../components/static_map_entity"; import { Entity } from "../../entity"; @@ -471,10 +472,7 @@ export class HUDBuildingPlacerLogic extends BaseHUDPart { .pressed ? -1 : 1; - let newIndex = (index + direction) % availableVariants.length; - if (newIndex < 0) { - newIndex += availableVariants.length; - } + let newIndex = safeModulo(index + direction, availableVariants.length); const newVariant = availableVariants[newIndex]; this.setVariant(newVariant); }