From 39c68ee97c8a5f925b38f9f1d35e2a0bfa39cf67 Mon Sep 17 00:00:00 2001 From: Yoshie2000 Date: Mon, 31 Aug 2020 13:29:04 +0200 Subject: [PATCH] Type safety fixes --- src/js/platform/sound.js | 2 +- src/js/profile/setting_types.js | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/js/platform/sound.js b/src/js/platform/sound.js index 3983f08f..f578ff68 100644 --- a/src/js/platform/sound.js +++ b/src/js/platform/sound.js @@ -130,7 +130,7 @@ export class SoundInterface { this.musicMuted = this.app.settings.getAllSettings().musicMuted; this.soundsMuted = this.app.settings.getAllSettings().soundsMuted; this.musicVolume = this.app.settings.getAllSettings().musicVolume; - this.soundVolume = this.app.settings.getAllSettings().soundsVolume; + this.soundVolume = this.app.settings.getAllSettings().soundVolume; if (G_IS_DEV && globalConfig.debug.disableMusic) { this.musicMuted = true; diff --git a/src/js/profile/setting_types.js b/src/js/profile/setting_types.js index d21ad1bd..3b884c58 100644 --- a/src/js/profile/setting_types.js +++ b/src/js/profile/setting_types.js @@ -272,12 +272,17 @@ export class RangeSetting extends BaseSetting { syncValueToElement() { const value = this.app.settings.getSetting(this.id); - this.element.querySelector(".range-input").value = value; - this.element.querySelector(".range-label").innerText = value; + /** @type {HTMLInputElement} */ + const rangeInput = this.element.querySelector(".range-input"), + rangeLabel = this.element.querySelector(".range-label"); + rangeInput.value = value; + rangeLabel.innerHTML = value; } modify() { - const newValue = Number(this.element.querySelector(".range-input").value); + /** @type {HTMLInputElement} */ + const rangeInput = this.element.querySelector(".range-input"); + const newValue = Number(rangeInput.value); this.app.settings.updateSetting(this.id, newValue); this.syncValueToElement();