From 08d02b5bf6d6d2e8eff1e2dcf5164ad87147aad3 Mon Sep 17 00:00:00 2001 From: christos Date: Fri, 27 Mar 2020 13:05:02 +0000 Subject: [PATCH] Fixed download.sh logic for multiple arguments. Removed Readme section about executing script from anywhere. Updated the parsing of URLs to be more specific. --- scripts/README.md | 2 -- scripts/download.sh | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/scripts/README.md b/scripts/README.md index d2d8d3e..bb4e7e5 100644 --- a/scripts/README.md +++ b/scripts/README.md @@ -20,5 +20,3 @@ Optionally, to download specific topics specify their directories as arguments: ```bash $ ./scripts/download.sh android concurrency ``` - -This can be run from anywhere as long as the script doesn't change location \ No newline at end of file diff --git a/scripts/download.sh b/scripts/download.sh index ebcc26f..d5139d4 100755 --- a/scripts/download.sh +++ b/scripts/download.sh @@ -16,7 +16,7 @@ download_for_directory() { done # Scrape URLs from markdown files - urls=$(ls | cat *.md 2> /dev/null | egrep -o 'https?://[^ ]+' | grep 'pdf' | tr -d ')') + urls=$(ls | cat *.md 2> /dev/null | egrep -o 'https?://[^ ]+' | grep '\.pdf' | tr -d ')') for url in "$urls"; do # Ignore empty URLs @@ -30,7 +30,7 @@ download_for_directory() { } # If no directories are supplied, iterate over the entire repo. -if [[ "$#" -ne 1 ]]; then +if [[ "$#" -eq 0 ]]; then REPO_ROOT_DIR="$(dirname $0)/.." download_for_directory ${REPO_ROOT_DIR} else