From bb81931ce9324d6d954e3b5ae42c127753a03868 Mon Sep 17 00:00:00 2001 From: Oliver Giles Date: Fri, 8 Mar 2019 08:20:41 +0200 Subject: [PATCH] regression fix: badge url badge urls were returning 404 and an exception message since cec4721e. Fixed by correctly extracting the job name from the request URL --- src/server.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.cpp b/src/server.cpp index ba6d297..8e50eff 100644 --- a/src/server.cpp +++ b/src/server.cpp @@ -435,7 +435,7 @@ private: responseHeaders.add("Content-Transfer-Encoding", "binary"); auto stream = response.send(200, "OK", responseHeaders, end-start); return stream->write(start, end-start).attach(kj::mv(stream)); - } else if(url.startsWith("/badge/") && url.endsWith(".svg") && laminar.handleBadgeRequest(url.slice(7, url.size()-11).begin(), badge)) { + } else if(url.startsWith("/badge/") && url.endsWith(".svg") && laminar.handleBadgeRequest(std::string(url.begin()+7, url.size()-11), badge)) { responseHeaders.set(kj::HttpHeaderId::CONTENT_TYPE, "image/svg+xml"); responseHeaders.add("Cache-Control", "no-cache"); auto stream = response.send(200, "OK", responseHeaders, badge.size());