From bb087b72eefae5953aa3f3cd84d63ad21461f453 Mon Sep 17 00:00:00 2001 From: Oliver Giles Date: Tue, 9 Nov 2021 09:21:19 +1300 Subject: [PATCH] Revert "make taskFailed non-fatal" Originally reverted to prevent a crash when reading from an http client raised ECONNRESET. Although this prevented a crash, laminar stopped listening for http connections. That issue was resolved in 37bbf6ade4 (see #164), so make all exceptions fatal again. This reverts commit 02810309fcfe09f1b4eb283625d656260d0690ef. --- src/server.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/server.cpp b/src/server.cpp index e1792f3..f7aa4c0 100644 --- a/src/server.cpp +++ b/src/server.cpp @@ -172,5 +172,7 @@ kj::Promise Server::handleFdRead(kj::AsyncInputStream* stream, char* buffe void Server::taskFailed(kj::Exception &&exception) { //kj::throwFatalException(kj::mv(exception)); - fprintf(stderr, "taskFailed: %s\n", exception.getDescription().cStr()); + // prettier + fprintf(stderr, "fatal: %s\n", exception.getDescription().cStr()); + exit(EXIT_FAILURE); }