From 0f20a43f0a9ba8c7565723eab32270e3e6c5aed2 Mon Sep 17 00:00:00 2001 From: Marco Starker Date: Thu, 18 Apr 2019 13:46:30 +0200 Subject: [PATCH 1/5] fixing ES6 Module import for BROWSER_ALIAS_MAP --- src/constants.js | 8 ++------ src/utils.js | 2 +- test/unit/constants.js | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/constants.js b/src/constants.js index dfae9ee..855abab 100644 --- a/src/constants.js +++ b/src/constants.js @@ -1,6 +1,6 @@ // NOTE: this list must be up-to-date with browsers listed in // test/acceptance/useragentstrings.yml -const BROWSER_ALIASES_MAP = { +export default { 'Amazon Silk': 'amazon_silk', 'Android Browser': 'android', Bada: 'bada', @@ -35,8 +35,4 @@ const BROWSER_ALIASES_MAP = { 'WebOS Browser': 'webos', WeChat: 'wechat', 'Yandex Browser': 'yandex', -}; - -module.exports = { - BROWSER_ALIASES_MAP, -}; +} diff --git a/src/utils.js b/src/utils.js index 942c3db..46f2ed5 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,4 +1,4 @@ -import { BROWSER_ALIASES_MAP } from './constants.js'; +import BROWSER_ALIASES_MAP from './constants.js'; export default class Utils { /** diff --git a/test/unit/constants.js b/test/unit/constants.js index a8b2be6..de4a54b 100644 --- a/test/unit/constants.js +++ b/test/unit/constants.js @@ -1,5 +1,5 @@ import test from 'ava'; -import { BROWSER_ALIASES_MAP } from '../../src/constants'; +import BROWSER_ALIASES_MAP from '../../src/constants'; test('check duplicate aliases', (t) => { const aliasesList = Object.keys(BROWSER_ALIASES_MAP).map(value => (BROWSER_ALIASES_MAP[value])); From 7075f6c4d72c8399ee1037162711bf267de4ee20 Mon Sep 17 00:00:00 2001 From: Marco Starker Date: Thu, 18 Apr 2019 13:50:17 +0200 Subject: [PATCH 2/5] adding useless semicolon --- src/constants.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/constants.js b/src/constants.js index 855abab..65f840f 100644 --- a/src/constants.js +++ b/src/constants.js @@ -35,4 +35,4 @@ export default { 'WebOS Browser': 'webos', WeChat: 'wechat', 'Yandex Browser': 'yandex', -} +}; From 98f348ebd329664eadacbe65be03c8a6ff71fcd7 Mon Sep 17 00:00:00 2001 From: Marco Starker Date: Thu, 18 Apr 2019 16:09:16 +0200 Subject: [PATCH 3/5] switching from default export to named export --- src/constants.js | 2 +- src/utils.js | 2 +- test/unit/constants.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/constants.js b/src/constants.js index 65f840f..e6b2d41 100644 --- a/src/constants.js +++ b/src/constants.js @@ -1,6 +1,6 @@ // NOTE: this list must be up-to-date with browsers listed in // test/acceptance/useragentstrings.yml -export default { +export const BROWSER_ALIASES_MAP = { 'Amazon Silk': 'amazon_silk', 'Android Browser': 'android', Bada: 'bada', diff --git a/src/utils.js b/src/utils.js index 46f2ed5..45bdc99 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,4 +1,4 @@ -import BROWSER_ALIASES_MAP from './constants.js'; +import {BROWSER_ALIASES_MAP} from './constants.js'; export default class Utils { /** diff --git a/test/unit/constants.js b/test/unit/constants.js index de4a54b..ee013c9 100644 --- a/test/unit/constants.js +++ b/test/unit/constants.js @@ -1,5 +1,5 @@ import test from 'ava'; -import BROWSER_ALIASES_MAP from '../../src/constants'; +import {BROWSER_ALIASES_MAP} from '../../src/constants'; test('check duplicate aliases', (t) => { const aliasesList = Object.keys(BROWSER_ALIASES_MAP).map(value => (BROWSER_ALIASES_MAP[value])); From 23c640f65f0dda4fba98db90508f723653910e25 Mon Sep 17 00:00:00 2001 From: Marco Starker Date: Sun, 21 Apr 2019 08:21:00 +0200 Subject: [PATCH 4/5] =?UTF-8?q?=F0=9F=99=84?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils.js b/src/utils.js index 45bdc99..942c3db 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,4 +1,4 @@ -import {BROWSER_ALIASES_MAP} from './constants.js'; +import { BROWSER_ALIASES_MAP } from './constants.js'; export default class Utils { /** From 11f3ae7009da5c83e1846555b2b7422b7782e8f8 Mon Sep 17 00:00:00 2001 From: Marco Starker Date: Sun, 21 Apr 2019 21:40:57 +0200 Subject: [PATCH 5/5] spaces --- test/unit/constants.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/constants.js b/test/unit/constants.js index ee013c9..a8b2be6 100644 --- a/test/unit/constants.js +++ b/test/unit/constants.js @@ -1,5 +1,5 @@ import test from 'ava'; -import {BROWSER_ALIASES_MAP} from '../../src/constants'; +import { BROWSER_ALIASES_MAP } from '../../src/constants'; test('check duplicate aliases', (t) => { const aliasesList = Object.keys(BROWSER_ALIASES_MAP).map(value => (BROWSER_ALIASES_MAP[value]));