From 428dadc503f2efb43160c1c994bbfbf700729162 Mon Sep 17 00:00:00 2001 From: Denis Demchenko Date: Sun, 7 Apr 2019 11:28:03 +0300 Subject: [PATCH] Fix Yandex Browser version detection fixes #308 --- src/parser-browsers.js | 2 +- test/acceptance/useragentstrings.yml | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/parser-browsers.js b/src/parser-browsers.js index 74b2bad..fd9469f 100644 --- a/src/parser-browsers.js +++ b/src/parser-browsers.js @@ -174,7 +174,7 @@ const browsersList = [ const browser = { name: 'Yandex Browser', }; - const version = Utils.getFirstMatch(commonVersionIdentifier, ua) || Utils.getFirstMatch(/(?:yabrowser)[\s/](\d+(\.?_?\d+)+)/i, ua); + const version = Utils.getFirstMatch(/(?:yabrowser)[\s/](\d+(\.?_?\d+)+)/i, ua) || Utils.getFirstMatch(commonVersionIdentifier, ua); if (version) { browser.version = version; diff --git a/test/acceptance/useragentstrings.yml b/test/acceptance/useragentstrings.yml index 5c05906..d3bd9b0 100644 --- a/test/acceptance/useragentstrings.yml +++ b/test/acceptance/useragentstrings.yml @@ -673,6 +673,22 @@ vendor: "Nexus" engine: name: "Blink" + - + ua: "Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 YaBrowser/19.3.3.157.10 Mobile/15E148 Safari/605.1" + spec: + browser: + name: "Yandex Browser" + version: "19.3.3.157.10" + os: + name: "iOS" + version: "12.2" + platform: + type: "mobile" + vendor: "Apple" + model: "iPhone" + engine: + name: "WebKit" + version: "605.1.15" Safari: - ua: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/537.13+ (KHTML, like Gecko) Version/5.1.7 Safari/534.57.2"