gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Florent	16ebc32611	Add tests for UsersManager (#1149 ) Context HomeDBManager lacks of direct tests, which makes hard to make rework or refactorations. Proposed solution Specifically here, I introduce tests which call exposed UsersManager methods directly and check their result. Also: I removed updateUserName which seems to me useless (updateUser does the same work) Taking a look at the getUserByLogin methods, it appears that Typescirpt infers it returns a Promise<User\|null> while in no case it may resolve a nullish value, therefore I have forced to return a Promise<User> and have changed the call sites to reflect the change. Related issues I make this change for then working on #870	3 weeks ago
Paul Fitzpatrick	fc3a7f580c	make access control for ConvertFromColumn action less brutal (#1111 ) Access control for ConvertFromColumn in the presence of access rules had previously been left as a TODO. This change allows the action when the user has schema rights. Because schema rights let you create formulas, they let you read anything, so there is currently no value in nuance here.	2 months ago
Paul Fitzpatrick	db52bb0082	(core) move test/server/lib/GranularAccess.ts to core Summary: Move an important set of tests that were in our SaaS repo for no good reason. Test Plan: moving tests Reviewers: jordigh Reviewed By: jordigh Differential Revision: https://phab.getgrist.com/D4300	2 months ago

Author

SHA1

Message

Date

Florent

16ebc32611

Add tests for UsersManager (#1149 )

Context

HomeDBManager lacks of direct tests, which makes hard to make rework or refactorations.
Proposed solution

Specifically here, I introduce tests which call exposed UsersManager methods directly and check their result.

Also:

    I removed updateUserName which seems to me useless (updateUser does the same work)
    Taking a look at the getUserByLogin methods, it appears that Typescirpt infers it returns a Promise<User|null> while in no case it may resolve a nullish value, therefore I have forced to return a Promise<User> and have changed the call sites to reflect the change.

Related issues

I make this change for then working on #870

Paul Fitzpatrick

fc3a7f580c

make access control for ConvertFromColumn action less brutal (#1111 )

Access control for ConvertFromColumn in the presence of access rules had previously been left as a TODO. This change allows the action when the user has schema rights. Because schema rights let you create formulas, they let you read anything, so there is currently no value in nuance here.

Paul Fitzpatrick

db52bb0082

(core) move test/server/lib/GranularAccess.ts to core

Summary:
Move an important set of tests that were in our SaaS
repo for no good reason.

Test Plan: moving tests

Reviewers: jordigh

Reviewed By: jordigh

Differential Revision: https://phab.getgrist.com/D4300

3 Commits (ef6a04ab2a305ac14a5ea2d1945d8f62e6ade443)