gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Jarosław Sadziński	0ca70e9d43	(core) Fixing lock issues and reverting back to single connection. Summary: Removing `createNewConnection` method that was used in tests to create a "scoped" version of `HomeDbManager`. Currently this won't work as there are many methods (like `Users.findOne`) that are using the default (global) connection. Additionally `HomeDBManger` had couple of bugs that were causing locks, which manifested themselves in postgresql tests (that are not serializing transactions). Repository methods like `Users.findOne` or `user.save()`, even when wrapped in transaction were using a separate connection from the pool (and a separate transaction). Some tests in `UsersManager` are still skipped or refactored, as sinon's `fakeTimers` doesn't work well with postgresql driver (which is using `setTimout` a lot). Date mappings in `User` entity were fixed, they were using `SQLite` configuration only, which caused problems with postgresql database. Test Plan: Refactored. Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D4342	2 weeks ago
Florent	16ebc32611	Add tests for UsersManager (#1149 ) Context HomeDBManager lacks of direct tests, which makes hard to make rework or refactorations. Proposed solution Specifically here, I introduce tests which call exposed UsersManager methods directly and check their result. Also: I removed updateUserName which seems to me useless (updateUser does the same work) Taking a look at the getUserByLogin methods, it appears that Typescirpt infers it returns a Promise<User\|null> while in no case it may resolve a nullish value, therefore I have forced to return a Promise<User> and have changed the call sites to reflect the change. Related issues I make this change for then working on #870	3 weeks ago
Florent	961b1c1956	Introduce TYPEORM_EXTRA env variable (#770 ) Co-authored-by: Florent FAYOLLE <florent.fayolle@beta.gouv.fr>	10 months ago
Paul Fitzpatrick	e9efac05f7	(core) remove ormconfig.js from saas build; more sendgrid logging Summary: This removes ormconfig.js from the saas build since it is no longer needed (and has always been a pain point). This expands some sendgrid logging to help figure out a problem. Test Plan: existing tests should pass Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3808	2 years ago
Paul Fitzpatrick	f7f76fb5e7	A set of tweaks to simplify electron packaging (#421 ) * Replace `ormconfig.js` with a newer mechanism of configuring TypeORM that can be included in the source code properly. The path to `ormconfig.js` has always been awkward to handle, and eliminating the file makes building different Grist setups a bit simpler. * Remove `electron` package. It is barely used, just for some old remnants of an older attempt at electron packaging. It was used for two types, which I left at `any` for now. More code pruning is no doubt possible here, but I'd rather do it when Electron packaging has solidified. * Add a hook for replacing the login system, and for adding some extra middleware the login system may need. * Add support for some more possible locations of Python, which arise when a standalone version of it is included in the Electron package. This isn't very general purpose, just configurations that I found useful. * Support using grist-core within a yarn workspace - the only tweak needed was webpack related. * Allow an external ID to be optionally associated with documents.	2 years ago
Paul Fitzpatrick	dcaa2b4f29	(core) move DocUsageBanner to ext Summary: grist-ee build was failing since it didn't have a DocUsageBanner implementation available. Made the implementation added to monorepo available, since it will be useful to improve the activation banner. Test Plan: manaul Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: georgegevoian Differential Revision: https://phab.getgrist.com/D3452	2 years ago
Paul Fitzpatrick	b9a4b2b58f	(core) add missing tsconfig file that affects IDEs Summary: I missed committing a file that is important for editing files comfortably in the ext directory in an IDE. This diff: * Adds tsconfig-base-ext.json - that was the only intended change * Unrelated: Forces all creation of connections to the home db through a new `getOrCreateConnection` method which changes the `busy_timeout` if using Sqlite. This was an attempt to fix random "database is locked" test failures. I believe multiple connections to the home db as an sqlite file do not happen in self-hosted Grist (where there is a single node process) or in our SaaS (where the database is in postgres). It does affect Grist started using `devServerMain.ts` (where multiple processes accessing same database are started) or various test configurations when extra database connections are opened. * Unrelated: I added a `busy_timeout` for session storage, when it uses Sqlite. Again, I don't believe this affects self-hosted Grist or our SaaS. * Tweaked a `BillingDiscount` test that looked perhaps vulnerable to a stripe request stalling. I can't be sure my tweaks actually help, since I didn't succeed in replicating the failures. Update: looks like the "locked" error can still happen :( Test Plan: manual Reviewers: jarek Reviewed By: jarek Subscribers: jarek Differential Revision: https://phab.getgrist.com/D3450	2 years ago
Paul Fitzpatrick	5ef889addd	(core) move home server into core Summary: This moves enough server material into core to run a home server. The data engine is not yet incorporated (though in manual testing it works when ported). Test Plan: existing tests pass Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2552	4 years ago

8 Commits (da6c39aa50126f38e86fe55dbc579149a93d6664)