From ed9514bae0a898d4e46dc1a620bb88f0274296c7 Mon Sep 17 00:00:00 2001 From: George Gevoian Date: Wed, 15 May 2024 11:49:09 -0700 Subject: [PATCH] (core) Revert Safari overflow fix Summary: The fix introduced a regression. Test Plan: Existing tests. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D4254 --- app/client/ui2018/menus.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/client/ui2018/menus.ts b/app/client/ui2018/menus.ts index 4fbaadc9..5d8fc776 100644 --- a/app/client/ui2018/menus.ts +++ b/app/client/ui2018/menus.ts @@ -166,7 +166,8 @@ const cssSubMenuElem = styled('div', ` min-width: 200px; `); -// Note: "overflow: visible" happens to matter for Safari. +// TODO: menus are sometimes cut off in Safari. +// Setting "overflow: visible fixes this, but breaks overflow elsewhere. export const cssMenuElem = styled('div', ` font-family: ${vars.fontFamily}; font-size: ${vars.mediumFontSize}; @@ -179,7 +180,6 @@ export const cssMenuElem = styled('div', ` --weaseljs-selected-background-color: ${theme.menuItemSelectedBg}; --weaseljs-menu-item-padding: 8px 24px; background-color: ${theme.menuBg}; - overflow: visible; @media print { & {