From b5e0e020ef138447874dc7a86413fe6e0322f822 Mon Sep 17 00:00:00 2001 From: George Gevoian Date: Sun, 14 Jul 2024 22:37:10 -0400 Subject: [PATCH] (core) Disable SelectionSummary when diffing documents Summary: Cell values can't be summarized if they are diffs of two different document versions. This was causing a JS error to be thrown when comparing snapshots. Test Plan: Browser test. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D4292 --- app/client/components/GridView.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/client/components/GridView.js b/app/client/components/GridView.js index e59577ec..8e3761ff 100644 --- a/app/client/components/GridView.js +++ b/app/client/components/GridView.js @@ -96,8 +96,7 @@ function GridView(gristDoc, viewSectionModel, isPreview = false) { this.cellSelector = selector.CellSelector.create(this, this); - if (!isPreview) { - // Disable summaries in import previews, for now. + if (!isPreview && !this.gristDoc.comparison) { this.selectionSummary = SelectionSummary.create(this, this.cellSelector, this.tableModel.tableData, this.sortedRows, this.viewSection.viewFields); }