From 6864649b9214950f5bb20fed802ccbae6d6a1517 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaros=C5=82aw=20Sadzi=C5=84ski?= Date: Mon, 30 Jan 2023 15:52:56 +0100 Subject: [PATCH] Removing toast errors on missing keys --- app/client/lib/localization.ts | 11 ----------- app/client/ui/AccountPage.ts | 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/app/client/lib/localization.ts b/app/client/lib/localization.ts index 0167e190..39094809 100644 --- a/app/client/lib/localization.ts +++ b/app/client/lib/localization.ts @@ -95,11 +95,6 @@ type InferResult = T extends Record|undefi * Resolves the translation of the given key and substitutes. Supports dom elements interpolation. */ export function t>(key: string, args?: T|null, instance = i18next): InferResult { - if (!instance.exists(key, args || undefined)) { - const error = new Error(`Missing translation for key: ${key} and language: ${i18next.language}`); - reportError(error); - } - // Don't need to bind `t` function. return domT(key, args, instance.t); } @@ -177,12 +172,6 @@ export function makeT(scope: string, instance?: typeof i18next) { // This will remove all the overloads from the function, but we don't need them. scopedResolver = (_key: string, _args?: any) => fixedResolver(_key, {defaultValue: _key, ..._args}); } - // If the key has interpolation or we did pass some arguments, make sure that - // the key exists. - if ((args || key.includes("{{")) && !scopedInstance.exists(`${scope}.${key}`, args || undefined)) { - const error = new Error(`Missing translation for key: ${key} and language: ${i18next.language}`); - reportError(error); - } return domT(key, args, scopedResolver!); }; } diff --git a/app/client/ui/AccountPage.ts b/app/client/ui/AccountPage.ts index 81a46746..5cc5f6d9 100644 --- a/app/client/ui/AccountPage.ts +++ b/app/client/ui/AccountPage.ts @@ -141,7 +141,7 @@ export class AccountPage extends Disposable { enableCustomCss ? null : [ css.header(t("Theme")), dom.create(ThemeConfig, this._appModel), - css.subHeader(t("Language ")), + css.subHeader(t("Language")), css.dataRow({ style: 'width: 300px'}, select(userLocale, languageOptions, { renderOptionArgs: () => {