From 716144ed4646f36a8745d50ac3c1d0e0b8a05261 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaros=C5=82aw=20Sadzi=C5=84ski?=
 <jaroslaw.sadzinski@gmail.com>
Date: Tue, 30 Jan 2024 17:25:24 +0100
Subject: [PATCH] (core) Hiding creator panel when raw data page is active.

Summary:
Creator panel was showing a header with tabs on Raw Data page. This
was broken by forms feature lately.

Test Plan: Added

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: georgegevoian

Differential Revision: https://phab.getgrist.com/D4179
---
 app/client/ui/RightPanel.ts | 4 +++-
 test/nbrowser/RawData.ts    | 6 ++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/app/client/ui/RightPanel.ts b/app/client/ui/RightPanel.ts
index 567fd78b..0dfab821 100644
--- a/app/client/ui/RightPanel.ts
+++ b/app/client/ui/RightPanel.ts
@@ -123,6 +123,8 @@ export class RightPanel extends Disposable {
     return use(this._pageWidgetType) === 'form';
   });
 
+  private _hasActiveWidget = Computed.create(this, (use) => Boolean(use(this._pageWidgetType)));
+
   // Returns the active section if it's valid, null otherwise.
   private _validSection = Computed.create(this, (use) => {
     const sec = use(this._gristDoc.viewModel.activeSection);
@@ -253,7 +255,7 @@ export class RightPanel extends Disposable {
             dom.create(this._buildPageFormHeader.bind(this)),
             dom.create(this._buildPageWidgetContent.bind(this)),
           ];
-        } else {
+        } else if (use(this._hasActiveWidget)) {
           return [
             dom.create(this._buildPageWidgetHeader.bind(this)),
             dom.create(this._buildPageWidgetContent.bind(this)),
diff --git a/test/nbrowser/RawData.ts b/test/nbrowser/RawData.ts
index d3bb3258..606530ab 100644
--- a/test/nbrowser/RawData.ts
+++ b/test/nbrowser/RawData.ts
@@ -32,6 +32,12 @@ describe('RawData', function () {
     assert.deepEqual(uiTables, tables);
   });
 
+  it('shows blank creator panel', async function () {
+    await gu.toggleSidePanel('right', 'open');
+    assert.isEmpty(await driver.find('.test-right-panel').getText());
+    await gu.toggleSidePanel('right', 'close');
+  });
+
   it('shows row counts of all tables', async function () {
     assert.deepEqual(await getRawTableRows(), [
       '4,079',