From 6b338256e0142443b9b29da6116b03c14072fadc Mon Sep 17 00:00:00 2001 From: Dmitry S Date: Wed, 31 May 2023 15:38:25 -0400 Subject: [PATCH] (core) On mobile, only show a warning for older and unknown browsers rather than for all Test Plan: Tested listed versions against docs.getgrist.com using browserstack, and tested with an iPhone and local server that new settings are noticed on mobile. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3909 --- app/client/browserCheck.ts | 9 ++++++++- static/app.html | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/client/browserCheck.ts b/app/client/browserCheck.ts index e2fd6aac..2d99ef11 100644 --- a/app/client/browserCheck.ts +++ b/app/client/browserCheck.ts @@ -20,7 +20,14 @@ if (document && window && document.cookie.indexOf("gristbrowser=accept") === -1) safari: ">=12.0.3", // first 2019 version edge: ">=80", // one of first Chromium-based Edge versions, early 2020 opera: ">=66", // first 2020 version - } + }, + mobile: { + // These were tested using browserstack, for a basic layout and cell editing. Other browsers + // not attempted, so Grist will show a warning there. + safari: ">=15", // 2021 version, first where layouts aren't broken + chrome: ">=92", // 2021 version which works fine + firefox: ">=108", // end-of-2022 version, couldn't try an earlier one + }, }); const isMobile = version.isPlatform('mobile') || version.isPlatform('tablet'); if (!isHappyBrowser) { diff --git a/static/app.html b/static/app.html index b346435f..f87de801 100644 --- a/static/app.html +++ b/static/app.html @@ -49,7 +49,7 @@ Grist works best on modern Firefox or Chrome. - Grist mobile support is a work in progress. + Grist mobile works best on modern Firefox, Chrome, or Safari. Learn more