From 5af2cd4ef723b717ac601c45bb13dd5d3b0a07c3 Mon Sep 17 00:00:00 2001
From: Louis Delbosc <louis.delbosc.prestataire@anct.gouv.fr>
Date: Thu, 2 Mar 2023 03:52:12 +0100
Subject: [PATCH] Add translation for visible field config (#442)

---
 app/client/ui/VisibleFieldsConfig.ts | 8 ++++----
 static/locales/en.client.json        | 6 +++++-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/app/client/ui/VisibleFieldsConfig.ts b/app/client/ui/VisibleFieldsConfig.ts
index c52e543a..4222fd8d 100644
--- a/app/client/ui/VisibleFieldsConfig.ts
+++ b/app/client/ui/VisibleFieldsConfig.ts
@@ -198,7 +198,7 @@ export class VisibleFieldsConfig extends Disposable {
     });
     return [
       cssHeader(
-        cssFieldListHeader(dom.text((use) => `Visible ${use(this._fieldLabel)}`)),
+        cssFieldListHeader(dom.text((use) => t("Visible {{label}}", {label: use(this._fieldLabel)}))),
         dom.maybe(
           (use) => Boolean(use(use(this._section.viewFields).getObservable()).length),
           () => (
@@ -215,7 +215,7 @@ export class VisibleFieldsConfig extends Disposable {
       dom.maybe(this._showVisibleBatchButtons, () =>
         cssRow(
           primaryButton(
-            dom.text((use) => `Hide ${use(this._fieldLabel)}`),
+            dom.text((use) => t("Hide {{label}}", {label: use(this._fieldLabel)})),
             dom.on('click', () => this._removeSelectedFields()),
           ),
           basicButton(
@@ -234,7 +234,7 @@ export class VisibleFieldsConfig extends Disposable {
           testId('collapse-hidden'),
         ),
         // TODO: show `hidden column` only when some fields are hidden
-        cssFieldListHeader(dom.text((use) => `Hidden ${use(this._fieldLabel)}`)),
+        cssFieldListHeader(dom.text((use) => t("Hidden {{label}}", {label: use(this._fieldLabel)}))),
         dom.maybe(
           (use) => Boolean(use(this._hiddenFields.getObservable()).length && !use(this._collapseHiddenFields)),
           () => (
@@ -257,7 +257,7 @@ export class VisibleFieldsConfig extends Disposable {
         dom.maybe(this._showHiddenBatchButtons, () =>
           cssRow(
             primaryButton(
-              dom.text((use) => `Show ${use(this._fieldLabel)}`),
+              dom.text((use) => t("Show {{label}}", {label: use(this._fieldLabel)})),
               dom.on('click', () => this._addSelectedFields()),
             ),
             basicButton(
diff --git a/static/locales/en.client.json b/static/locales/en.client.json
index 0f30660a..a47af552 100644
--- a/static/locales/en.client.json
+++ b/static/locales/en.client.json
@@ -688,7 +688,11 @@
         "Cannot drop items into Hidden Fields": "Cannot drop items into Hidden Fields",
         "Clear": "Clear",
         "Hidden Fields cannot be reordered": "Hidden Fields cannot be reordered",
-        "Select All": "Select All"
+        "Select All": "Select All",
+        "Visible {{label}}": "Visible {{label}}",
+        "Hide {{label}}": "Hide {{label}}",
+        "Hidden {{label}}": "Hidden {{label}}",
+        "Show {{label}}": "Show {{label}}"
     },
     "WelcomeQuestions": {
         "Education": "Education",