From 4b06bf95f5256aad2b928c0331057a0b3e40794c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Cutzach?= <gregoire@cutzach.com>
Date: Tue, 10 Sep 2024 15:04:58 +0200
Subject: [PATCH] fix: lower number of queries in email delta check

---
 app/gen-server/lib/homedb/UsersManager.ts | 35 ++++++++++++++++++++---
 1 file changed, 31 insertions(+), 4 deletions(-)

diff --git a/app/gen-server/lib/homedb/UsersManager.ts b/app/gen-server/lib/homedb/UsersManager.ts
index e2be5b1d..48729960 100644
--- a/app/gen-server/lib/homedb/UsersManager.ts
+++ b/app/gen-server/lib/homedb/UsersManager.ts
@@ -346,6 +346,22 @@ export class UsersManager {
       .getOne() || undefined;
   }
 
+  /**
+   * Find some users by their emails. Don't create the users if they don't already exist.
+   */
+  public async getExistingUsersByLogin(
+    emails: string[],
+    manager?: EntityManager
+  ): Promise<User[]> {
+    const normalizedEmails = emails.map(email=> normalizeEmail(email));
+    return await (manager || this._connection).createQueryBuilder()
+      .select('user')
+      .from(User, 'user')
+      .leftJoinAndSelect('user.logins', 'logins')
+      .where('email IN (:...emails)', {emails: normalizedEmails})
+      .getMany();
+  }
+
   /**
    *
    * Fetches a user record based on an email address. If a user record already
@@ -471,7 +487,11 @@ export class UsersManager {
     });
   }
 
-  /**
+  public async createUser(email: string, options: GetUserOptions = {}): Promise<User|undefined> {
+    return await this.getUserByLogin(email, options);
+  }
+
+  /*
    * Deletes a user from the database. For the moment, the only person with the right
    * to delete a user is the user themselves.
    * Users have logins, a personal org, and entries in the group_users table. All are
@@ -612,9 +632,16 @@ export class UsersManager {
       // Lookup emails
       const emailMap = delta.users;
       const emails = Object.keys(emailMap);
-      const emailUsers = await Promise.all(
-        emails.map(async email => await this.getUserByLogin(email, {manager: transaction}))
-      );
+      const existingUsers = await this.getExistingUsersByLogin(emails, transaction);
+      const emailsExistingUsers = existingUsers.map(user=>user.loginEmail);
+      const emailsUsersToCreate = emails.filter(email => ! emailsExistingUsers.includes(email));
+      for (const email of emailsUsersToCreate){
+        const user = await this.createUser(email, {manager: transaction});
+        if (user !== undefined) {
+          existingUsers.push(user);
+        }
+      }
+      const emailUsers = [...existingUsers];
       emails.forEach((email, i) => {
         const userIdAffected = emailUsers[i]!.id;
         // Org-level sharing with everyone would allow serious spamming - forbid it.