From 2f485c5435979bb362f5cd23e6cf95a37e939e5b Mon Sep 17 00:00:00 2001 From: George Gevoian <85144792+georgegevoian@users.noreply.github.com> Date: Mon, 6 Nov 2023 12:49:32 -0500 Subject: [PATCH] Fix failing Docker tests (#724) --- test/nbrowser/ActionLog.ts | 2 +- test/nbrowser/ChoiceList.ts | 2 +- test/nbrowser/gristUtils.ts | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/test/nbrowser/ActionLog.ts b/test/nbrowser/ActionLog.ts index cb37e20c..8458aed8 100644 --- a/test/nbrowser/ActionLog.ts +++ b/test/nbrowser/ActionLog.ts @@ -133,7 +133,7 @@ describe('ActionLog', function() { assert.equal(await gu.getActiveCell().getText(), 'f'); // Delete Table1Renamed. - await gu.removeTable('Table1Renamed'); + await gu.removeTable('Table1Renamed', {dismissTips: true}); await driver.findContent('.action_log label', /All tables/).find('input').click(); const item4 = await getActionLogItem(4); diff --git a/test/nbrowser/ChoiceList.ts b/test/nbrowser/ChoiceList.ts index e572646d..f894648b 100644 --- a/test/nbrowser/ChoiceList.ts +++ b/test/nbrowser/ChoiceList.ts @@ -454,7 +454,7 @@ describe('ChoiceList', function() { it('should allow ChoiceList conversions for column used in summary', async function() { // Add a widget with a summary on column A. - await gu.addNewSection(/Table/, /Table1/, {summarize: [/^A$/]}); + await gu.addNewSection(/Table/, /Table1/, {dismissTips: true, summarize: [/^A$/]}); await testTextChoiceListConversions(); await gu.undo(); }); diff --git a/test/nbrowser/gristUtils.ts b/test/nbrowser/gristUtils.ts index 1f22cc48..840e56cd 100644 --- a/test/nbrowser/gristUtils.ts +++ b/test/nbrowser/gristUtils.ts @@ -1237,8 +1237,9 @@ export async function renameColumn(col: IColHeader|string, newName: string) { /** * Removes a table using RAW data view. */ -export async function removeTable(tableId: string) { +export async function removeTable(tableId: string, options: {dismissTips?: boolean} = {}) { await driver.find(".test-tools-raw").click(); + if (options.dismissTips) { await dismissBehavioralPrompts(); } const tableIdList = await driver.findAll('.test-raw-data-table-id', e => e.getText()); const tableIndex = tableIdList.indexOf(tableId); assert.isTrue(tableIndex >= 0, `No raw table with id ${tableId}`);