From 2ea8b8d71f4f5c871df3b6bc24a0ef3a1ec8bf19 Mon Sep 17 00:00:00 2001 From: Dmitry S Date: Sat, 12 Sep 2020 00:00:55 -0400 Subject: [PATCH] (core) After a spate of spurious test failures, try to fix a few. Summary: - Disable a pointless timing check in Python that occasionally fails. - Make the test of InvalidValues more robust by waiting for calculated values to load. - Make Snapshots test more robust by waiting for an action that precedes a URL change. Test Plan: These tests should fail less often when the tested logic is correct. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2609 --- sandbox/grist/test_match_counter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sandbox/grist/test_match_counter.py b/sandbox/grist/test_match_counter.py index 128d24bd..7d135dff 100644 --- a/sandbox/grist/test_match_counter.py +++ b/sandbox/grist/test_match_counter.py @@ -139,7 +139,7 @@ m4 = t.MatchCounterIntersection(t.sample) t4 = min(timeit.repeat(stmt='m4.count_unique(t.data3)', setup=setup, number=N, repeat=3)) / N #print "Timings/iter data3: %.3fus %.3fus %.3fus %.3fus" % (t1 * 1e6, t2 * 1e6, t3*1e6, t4*1e6) self.assertLess(t1, t2) - self.assertLess(t1, t3) + #self.assertLess(t1, t3) # This fails on occasion, but it's a fairly pointless check. self.assertLess(t1, t4)