From 271a5735c367b103604ca9358e2fcff565bef15f Mon Sep 17 00:00:00 2001 From: George Gevoian Date: Tue, 4 Jul 2023 21:13:53 -0400 Subject: [PATCH] (core) Fix focus bug in filter menu Summary: It was impossible to focus the search input in the filter menu if either of the range filter inputs were focused. Test Plan: Browser test. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3942 --- app/client/ui/ColumnFilterMenu.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/client/ui/ColumnFilterMenu.ts b/app/client/ui/ColumnFilterMenu.ts index c9fa0965..0d6fb8d3 100644 --- a/app/client/ui/ColumnFilterMenu.ts +++ b/app/client/ui/ColumnFilterMenu.ts @@ -470,9 +470,13 @@ function numericInput(obs: Observable, editMode = false; inputEl.value = formatValue(obs.get()); - // Make sure focus is trapped on input during calendar view, so that uses can still use keyboard - // to navigate relative date options just after picking a date on the calendar. - setTimeout(() => opts.isSelected.get() && inputEl.focus()); + setTimeout(() => { + // Make sure focus is trapped on input during calendar view, so that uses can still use keyboard + // to navigate relative date options just after picking a date on the calendar. + if (opts.viewTypeObs.get() === 'calendarView' && opts.isSelected.get()) { + inputEl.focus(); + } + }); }; const onInput = debounce(() => { if (isRelativeBound(obs.get())) { return; }