From ae484a82342e8c80ec9bb3a3aed41f75d8d2dfe0 Mon Sep 17 00:00:00 2001
From: gnosygnu <gnosygnu@gmail.com>
Date: Mon, 25 Nov 2019 16:43:11 -0500
Subject: [PATCH] Pagebanner: Add extra space after hasPosition or some
 pageBanners will omit wpb-banner-image [#618]

---
 400_xowa/src/gplx/xowa/xtns/pagebanners/Pgbnr_func_tst.java    | 3 ++-
 .../any/xowa/xtns/WikidataPageBanner/templates/banner.mustache | 2 +-
 res/bin/any/xowa/xtns/WikidataPageBanner/templates/readme.txt  | 2 ++
 3 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100644 res/bin/any/xowa/xtns/WikidataPageBanner/templates/readme.txt

diff --git a/400_xowa/src/gplx/xowa/xtns/pagebanners/Pgbnr_func_tst.java b/400_xowa/src/gplx/xowa/xtns/pagebanners/Pgbnr_func_tst.java
index 01f953efe..333e96bcb 100644
--- a/400_xowa/src/gplx/xowa/xtns/pagebanners/Pgbnr_func_tst.java
+++ b/400_xowa/src/gplx/xowa/xtns/pagebanners/Pgbnr_func_tst.java
@@ -44,7 +44,8 @@ public class Pgbnr_func_tst {
 		( "<div class='ext-wpb-pagebanner pre-content'>"
 		, " <div class='wpb-topbanner'>"
 		, "		<h1 class='wpb-name'>Test page</h1>"
-		, "		<a href='/wiki/File:A.png' class='image' title='Test page' xowa_title='A.png'><img data-xowa-title=\"A.png\" data-xoimg=\"1|-1|-1|-1|-1|-1\" src='' width='0' height='0' class='wpb-banner-image ' alt='' srcset='' data-pos-x='0' data-pos-y='0' style='max-width:0px'></a>"
+		, "		<a href='/wiki/File:A.png' class='image' title='Test page' xowa_title='A.png'>"
+		+         "<img data-xowa-title=\"A.png\" data-xoimg=\"1|-1|-1|-1|-1|-1\" src='' width='0' height='0' class='wpb-banner-image ' alt='' srcset='' data-pos-x='0' data-pos-y='0' style='max-width:0px'></a>"
 		, "		<div class='wpb-iconbox'>"
 		, "				<a href='/wiki/Star_article'><span aria-disabled='false' title='Star article' class='oo-ui-widget oo-ui-widget-enabled oo-ui-iconElement-icon oo-ui-icon-star oo-ui-iconElement oo-ui-iconWidget'></span></a>"
 		, "		</div>"
diff --git a/res/bin/any/xowa/xtns/WikidataPageBanner/templates/banner.mustache b/res/bin/any/xowa/xtns/WikidataPageBanner/templates/banner.mustache
index 0e1091833..0c6366b50 100644
--- a/res/bin/any/xowa/xtns/WikidataPageBanner/templates/banner.mustache
+++ b/res/bin/any/xowa/xtns/WikidataPageBanner/templates/banner.mustache
@@ -1,7 +1,7 @@
 <div class="ext-wpb-pagebanner pre-content">
 	<div class="{{#isPanorama}}wpb-banner-image-panorama {{/isPanorama}}wpb-topbanner{{extraClass}}">
 		{{#isHeadingOverrideEnabled}}<h1 class="wpb-name">{{title}}</h1>{{/isHeadingOverrideEnabled}}
-		<a class="image" dir="ltr" title="{{tooltip}}" href="{{bannerfile}}" xowa_title="{{file_ttl}}"><img{{{img_id_atr}}}{{{img_xottl}}}{{{img_xoimg}}} src="{{banner}}" srcset="{{srcset}}" class="wpb-banner-image"{{#hasPosition}} data-pos-x="{{data-pos-x}}" data-pos-y="{{data-pos-y}}" {{/hasPosition}}style="max-width:{{maxWidth}}px"></a>
+		<a class="image" dir="ltr" title="{{tooltip}}" href="{{bannerfile}}" xowa_title="{{file_ttl}}"><img{{{img_id_atr}}}{{{img_xottl}}}{{{img_xoimg}}} src="{{banner}}" srcset="{{srcset}}" class="wpb-banner-image"{{#hasPosition}} data-pos-x="{{data-pos-x}}" data-pos-y="{{data-pos-y}}" {{/hasPosition}} style="max-width:{{maxWidth}}px"></a>
 		{{#hasIcons}}
 		<div class="wpb-iconbox">
 			{{#icons}}
diff --git a/res/bin/any/xowa/xtns/WikidataPageBanner/templates/readme.txt b/res/bin/any/xowa/xtns/WikidataPageBanner/templates/readme.txt
new file mode 100644
index 000000000..53606c3e9
--- /dev/null
+++ b/res/bin/any/xowa/xtns/WikidataPageBanner/templates/readme.txt
@@ -0,0 +1,2 @@
+REF: https://github.com/wikimedia/mediawiki-extensions-WikidataPageBanner/blob/master/templates/banner.mustache
+SYNC: 2019-11-25
\ No newline at end of file