From 50d1fbfed1d6a7172a3ec709787d439fe1c7bff4 Mon Sep 17 00:00:00 2001 From: gnosygnu Date: Wed, 14 Nov 2018 23:28:26 -0500 Subject: [PATCH] Category: Add comment and change casting order [#269] --- 400_xowa/src/gplx/core/intls/ucas/Uca_collator__icu__4_8.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/400_xowa/src/gplx/core/intls/ucas/Uca_collator__icu__4_8.java b/400_xowa/src/gplx/core/intls/ucas/Uca_collator__icu__4_8.java index d70734bfe..ad63389bd 100644 --- a/400_xowa/src/gplx/core/intls/ucas/Uca_collator__icu__4_8.java +++ b/400_xowa/src/gplx/core/intls/ucas/Uca_collator__icu__4_8.java @@ -24,8 +24,8 @@ class Uca_collator__icu__4_8 implements Uca_collator { try { this.collator = Collator.getInstance(Locale.forLanguageTag(locale)); if (numeric_ordering) { - RuleBasedCollator rbc = (RuleBasedCollator)collator; - rbc.setNumericCollation(true); + // NOTE: delaying cast to RuleBasedCollator b/c Collator.getInstance may return a non-RuleBasedCollator and don't want cast to fail if numeric_ordering is false + ((RuleBasedCollator)collator).setNumericCollation(true); } } catch (Exception e) {throw Err_.new_wo_type("collator init failed", "err", Err_.Message_lang(e));} }