From c366bba3437ca99e39298f6c11da519b967e35dc Mon Sep 17 00:00:00 2001 From: Falk Werner Date: Tue, 3 Jan 2023 20:56:07 +0100 Subject: [PATCH] add test for unlink --- CMakeLists.txt | 1 + src/webfuse/provider.cpp | 11 +++++++ test-src/integration/test_unlink.cpp | 44 ++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+) create mode 100644 test-src/integration/test_unlink.cpp diff --git a/CMakeLists.txt b/CMakeLists.txt index e63b02c..2fec69b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -84,6 +84,7 @@ if(NOT(WITHOUT_TEST)) test-src/integration/test_utimens.cpp test-src/integration/test_open.cpp test-src/integration/test_mknod.cpp + test-src/integration/test_unlink.cpp ) target_include_directories(integration_tests PRIVATE test-src/integration ${GTEST_INCLUDE_DIRS} ${GMOCK_INCLUDE_DIRS}) diff --git a/src/webfuse/provider.cpp b/src/webfuse/provider.cpp index 124c038..3a3fa0e 100644 --- a/src/webfuse/provider.cpp +++ b/src/webfuse/provider.cpp @@ -100,6 +100,9 @@ public: case request_type::release: fs_release(reader, writer); break; + case request_type::unlink: + fs_unlink(reader, writer); + break; case request_type::readdir: fs_readdir(reader, writer); break; @@ -272,6 +275,14 @@ private: writer.write_i32(result); } + void fs_unlink(messagereader & reader, messagewriter & writer) + { + auto const path = reader.read_str(); + + auto const result = fs_.unlink(path); + writer.write_i32(result); + } + void fs_readdir(messagereader & reader, messagewriter & writer) { auto const path = reader.read_str(); diff --git a/test-src/integration/test_unlink.cpp b/test-src/integration/test_unlink.cpp new file mode 100644 index 0000000..2d14ea5 --- /dev/null +++ b/test-src/integration/test_unlink.cpp @@ -0,0 +1,44 @@ +#include "webfuse/webfuse.hpp" +#include "webfuse/test/fixture.hpp" +#include "webfuse/test/filesystem_mock.hpp" + +#include + +using testing::_; +using testing::Return; +using testing::Invoke; +using testing::AnyNumber; + +TEST(unlink, success) +{ + bool link_created = false; + + webfuse::filesystem_mock fs; + EXPECT_CALL(fs, access("/",_)).Times(AnyNumber()).WillRepeatedly(Return(0)); + EXPECT_CALL(fs, getattr(_,_)).WillRepeatedly(Invoke([&link_created](std::string const & path, struct stat * attr){ + memset(reinterpret_cast(attr),0, sizeof(struct stat)); + + if (path == "/") + { + attr->st_nlink = 1; + attr->st_mode = S_IFDIR | 0755; + return 0; + } + if (path == "/some_file") + { + attr->st_nlink = 1; + attr->st_mode = S_IFREG | 0755; + return 0; + } + else + { + return -ENOENT; + } + })); + EXPECT_CALL(fs, unlink("/some_file")).WillOnce(Return(0)); + + webfuse::fixture fixture(fs); + auto const path = fixture.get_path() + "/some_file"; + + ASSERT_EQ(0, ::unlink(path.c_str())); +} \ No newline at end of file