From 4610b82d7811354b533fdcee09812d5f77af0aa4 Mon Sep 17 00:00:00 2001 From: Falk Werner Date: Fri, 6 Jan 2023 17:10:56 +0100 Subject: [PATCH] clang-tidy: enable default checks --- CMakeLists.txt | 2 +- src/webfuse/fuse.cpp | 1 - src/webfuse/ws/server.cpp | 7 ++++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 586cc15..fc41227 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -39,7 +39,7 @@ target_link_libraries(webfuse_static PUBLIC PkgConfig::FUSE PkgConfig::LWS) if(NOT(WITHOUT_CLANG_TIDY)) set_property( TARGET webfuse_static - PROPERTY CXX_CLANG_TIDY clang-tidy -checks=-*,readability-*,-readability-identifier-length -warnings-as-errors=*) + PROPERTY CXX_CLANG_TIDY clang-tidy -checks=readability-*,-readability-identifier-length -warnings-as-errors=*) endif() diff --git a/src/webfuse/fuse.cpp b/src/webfuse/fuse.cpp index 4132025..02b9f47 100644 --- a/src/webfuse/fuse.cpp +++ b/src/webfuse/fuse.cpp @@ -182,7 +182,6 @@ static int fs_readdir(char const * path, void * buffer, fuse_readdir_flags flags) { auto * const fs = fs_get_filesystem(); - auto handle = fs_get_handle(info); std::vector names; auto const result = fs->readdir(path, names); if (0 == result) diff --git a/src/webfuse/ws/server.cpp b/src/webfuse/ws/server.cpp index 8dde316..651a62c 100644 --- a/src/webfuse/ws/server.cpp +++ b/src/webfuse/ws/server.cpp @@ -45,7 +45,7 @@ void do_receive(void * in, int len, lws* wsi, user_data * data) { webfuse::messagereader reader(data->current_message); uint32_t id = reader.read_u32(); - uint8_t message_type = reader.read_u8(); + reader.read_u8(); // read message type: ToDo: use it std::lock_guard lock(data->mut); auto it = data->pending_responses.find(id); @@ -132,7 +132,7 @@ static int ws_server_callback(struct lws *wsi, enum lws_callback_reasons reason, { size_t size; unsigned char * raw_data = writer.get_data(size); - int const rc = lws_write(data->connection, raw_data, size, LWS_WRITE_BINARY); + lws_write(data->connection, raw_data, size, LWS_WRITE_BINARY); } if (has_more) @@ -178,7 +178,8 @@ public: context = lws_create_context(&info); - lws_vhost * const vhost = lws_create_vhost(context, &info); + lws_create_vhost(context, &info); + // lws_vhost * const vhost = lws_create_vhost(context, &info); // port = lws_get_vhost_port(vhost);