From a17073193b22ce308851d3c8d7f4c1842ccbf04f Mon Sep 17 00:00:00 2001 From: Jakub Chrzanowski Date: Fri, 2 Oct 2020 11:37:40 +0200 Subject: [PATCH] code review --- CHANGELOG.md | 2 +- README.md | 6 +++--- gradle.properties | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dffbda..4ca1d91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ## [Unreleased] ### Added -- Opt-out flag for bundling Kotlin standard library by default +- Fix default to opt-out of bundling Kotlin standard library in plugin distribution ### Changed - GitHub Actions: allow releasing plugin even for the base project diff --git a/README.md b/README.md index 75ff11b..acf09f6 100644 --- a/README.md +++ b/README.md @@ -77,15 +77,15 @@ The properties listed define the plugin itself or configure the [gradle-intellij ### Dependency on the Kotlin standard library Since Kotlin 1.4, a dependency on a standard library (`stdlib`) is added automatically. -In most cases, it is not necessary to attach such libraries within the bundled plugin. +In most cases, it is not necessary to distribute this library with a plugin. -The [gradle.properties][file:gradle.properties] file explicitly alters the default behaviour of the Kotlin plugin using the opt-out property: +The [gradle.properties][file:gradle.properties] file explicitly alters the default behaviour of the Kotlin Gradle plugin by specifying this opt-out property: ``` kotlin.stdlib.default.dependency = false ``` -For more details, read: [Dependency on the standard library][kotlin-docs-dependency-on-stdlib]. +For more details, please see: [Dependency on the standard library][kotlin-docs-dependency-on-stdlib] in Kotlin documentation~~~~. ## Plugin template structure diff --git a/gradle.properties b/gradle.properties index 9abbf46..840cbd5 100644 --- a/gradle.properties +++ b/gradle.properties @@ -12,5 +12,5 @@ platformVersion = 2019.3 platformDownloadSources = true # Opt-out flag for bundling Kotlin standard library. -# Read more: https://kotlinlang.org/docs/reference/using-gradle.html#dependency-on-the-standard-library +# See https://kotlinlang.org/docs/reference/using-gradle.html#dependency-on-the-standard-library for details. kotlin.stdlib.default.dependency = false