diff --git a/src/main/java/com/commafeed/backend/feeds/FeedParser.java b/src/main/java/com/commafeed/backend/feeds/FeedParser.java index 14f4a2c0..370daa8b 100644 --- a/src/main/java/com/commafeed/backend/feeds/FeedParser.java +++ b/src/main/java/com/commafeed/backend/feeds/FeedParser.java @@ -1,13 +1,11 @@ package com.commafeed.backend.feeds; -import java.io.ByteArrayInputStream; import java.io.StringReader; import java.util.Calendar; import java.util.Date; import java.util.List; import org.apache.commons.codec.digest.DigestUtils; -import org.apache.commons.lang.ArrayUtils; import org.apache.commons.lang.StringUtils; import org.apache.commons.lang.SystemUtils; import org.xml.sax.InputSource; diff --git a/src/main/java/com/commafeed/backend/services/UserService.java b/src/main/java/com/commafeed/backend/services/UserService.java index d363b398..48e3c7bb 100644 --- a/src/main/java/com/commafeed/backend/services/UserService.java +++ b/src/main/java/com/commafeed/backend/services/UserService.java @@ -10,6 +10,7 @@ import com.commafeed.backend.dao.UserDAO; import com.commafeed.backend.model.User; import com.commafeed.backend.model.UserRole; import com.commafeed.backend.model.UserRole.Role; +import com.google.common.base.Preconditions; @Stateless public class UserService { @@ -21,6 +22,9 @@ public class UserService { PasswordEncryptionService encryptionService; public User login(String name, String password) { + Preconditions.checkNotNull(name); + Preconditions.checkNotNull(password); + User user = userDAO.findByName(name); if (user != null && !user.isDisabled()) { boolean authenticated = encryptionService.authenticate(password, @@ -41,6 +45,9 @@ public class UserService { public User register(String name, String password, String email, Collection roles) { + Preconditions.checkNotNull(name); + Preconditions.checkNotNull(password); + if (userDAO.findByName(name) != null) { return null; }